Bug 1901106

Summary:	Review Request: rust-pam-sys - FFI rust crate
Product:	[Fedora] Fedora	Reporter:	ed-fedora <ed-fedora>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, orion, package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-16 20:51:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1901114, 1941896, 1944463

Description ed-fedora@s5h.net 2020-11-24 14:06:41 UTC

Spec URL: http://www.usenix.org.uk/rpm/rust-pam-sys.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-sys-0.5.6-1.fc34.src.rpm
Description: Rust FFI wrappers for the Linux Pluggable Authentication Modules
Fedora Account System Username: eneville

This is a dependency for rust-pam.

Comment 1 Robert-André Mauchin 🐧 2021-01-20 20:09:17 UTC

 - You should specify what you patched in a comment:

# Initial patched metadata
# Bump blah to X, PR: https://...
Patch0:         pam-sys-fix-metadata.diff

 Patching libc is unnecessary:

 [dependencies.libc]
-version = "0.2.39"
+version = "0.2"

0.2.39 will work with any patch number below 0.3

 - You must include the license files with %license in %files devel:

%files          devel
%license LICENSE-APACHE LICENSE-MIT

 - You should include CHANGELOG.md in %doc

%doc CHANGELOG.md README.md

Comment 2 Robert-André Mauchin 🐧 2021-01-20 20:16:27 UTC

 - You need to add a Requires for pam in the devel subpackage:

%package        devel
Summary:        %{summary}
BuildArch:      noarch
Requires:       pam-devel

%description    devel %{_description}

 - You should BuildRequires pam-devel like this:

%generate_buildrequires
%cargo_generate_buildrequires
echo 'pam-devel'

Comment 3 ed-fedora@s5h.net 2021-03-14 10:39:15 UTC

Thanks for looking, I believe the changes are now ready in the following:

Spec URL: http://www.usenix.org.uk/rpm/rust-pam-sys.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-sys-0.5.6-1.fc35.src.rpm
Description: Rust FFI wrappers for the Linux Pluggable Authentication Modules

Comment 4 Robert-André Mauchin 🐧 2021-03-14 16:22:23 UTC

Package approved. You still need to find a sponsor as described in https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Comment 5 Rémi Lauzier 2021-03-29 15:39:40 UTC

*** Bug 1943989 has been marked as a duplicate of this bug. ***

Comment 6 Robert-André Mauchin 🐧 2021-05-08 09:42:42 UTC

Sponsored.

Comment 7 Gwyn Ciesla 2021-05-28 19:32:20 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pam-sys

Comment 8 Orion Poplawski 2022-08-09 02:31:34 UTC

Robert-André - Are you still interested in rust packaging for Fedora?

Comment 9 ed-fedora@s5h.net 2022-08-16 20:37:33 UTC

This is here https://src.fedoraproject.org/rpms/rust-pam-sys, please let me know if I've misunderstood.

Comment 10 Fabio Valentini 2022-08-16 20:51:56 UTC

The only thing that's missing here is to close the bug, since the package was imported to Fedora.