Bug 1901114 - Review Request: rust-pam - wrappers for PAM
Summary: Review Request: rust-pam - wrappers for PAM
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1901106
Blocks: 1901118
TreeView+ depends on / blocked
 
Reported: 2020-11-24 14:22 UTC by ed-fedora@s5h.net
Modified: 2022-05-24 12:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-24 12:36:12 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description ed-fedora@s5h.net 2020-11-24 14:22:26 UTC
Spec URL: http://www.usenix.org.uk/rpm/rust-pam.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-0.7.0-1.fc34.src.rpm
Description: Safe Rust wrappers for PAM authentication
Fedora Account System Username: eneville

Safe Rust wrappers for PAM authentication. Requires rust-pam-sys, which is my first review request.

Comment 1 Robert-André Mauchin 🐧 2021-01-20 20:25:46 UTC
 - Please explain your patches in a comment and provide upstream PR you have made

# Initial patched metadata
# Bump X to X, link to upstream PR
Patch0:         pam-fix-metadata.diff
# Fix XXX
Patch1:         pam-fix-authenticator.diff

 - You must include the license files with %license in %files devel:

%files          devel
%license LICENSE-APACHE LICENSE-MIT

 - You should include CHANGELOG.md in %doc

%doc CHANGELOG.md README.md

 - Build fails:

Error: 
 Problem: nothing provides requested (crate(rpassword/default) >= 4.0.0 with crate(rpassword/default) < 5.0.0~)

Comment 2 Robert-André Mauchin 🐧 2021-01-20 20:38:20 UTC
You should bump the dep to rpassword to 5 if possible

Comment 3 ed-fedora@s5h.net 2021-03-14 11:47:27 UTC
Hello, I believe the changes requested are now ready in the following:

Spec URL: http://www.usenix.org.uk/rpm/rust-pam.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-0.7.0-1.fc35.src.rpm

Thanks

Comment 4 Robert-André Mauchin 🐧 2021-03-14 16:21:22 UTC
Package approved. You still need to find a sponsor as described in https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Comment 5 Robert-André Mauchin 🐧 2021-05-08 09:44:06 UTC
Sponsored.

Comment 6 Gwyn Ciesla 2021-05-28 19:32:00 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pam

Comment 7 Package Review 2022-05-24 12:36:12 UTC
Package is available in repositories, closing.


Note You need to log in before you can comment on or make changes to this bug.