Bug 190243

Summary: Review Request: scim-bridge (gtkimm module in C)
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: Package ReviewAssignee: Warren Togami <wtogami>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eng-i18n-bugs
Target Milestone: ---Keywords: i18n
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-05-30 07:54:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 167798, 171491    

Description Jens Petersen 2006-04-29 04:53:08 UTC
Spec URL: http://people.redhat.com/petersen/extras/scim-bridge.spec
SRPM URL: http://people.redhat.com/petersen/extras/scim-bridge-0.1.6-15.src.rpm
Description:
SCIM Bridge is an alternative Gtk Input Method module for SCIM
implemented in C (ie it does not depend on libscim and libstdc++)
to avoid libstdc++ symbol ABI conflicts.

Comment 1 UTUMI Hirosi 2006-05-10 06:42:32 UTC
1. scim-bridge-0.1.7 is released.
It's there.
http://sourceforge.net/project/showfiles.php?group_id=108454&package_id=185651

2. Source1 doesn't have entries for QT_IM_MODULE and XMODIFIERS.
$ leafpad xinput-scim-bridge
//
GTK_IM_MODULE=scim-bridge
+ QT_IM_MODULE=scim
+ XMODIFIERS=@im=SCIM
//

3. scim-bridge doesn't lead scim and scim-qtimm.
We need to add some Requires.
$ leafpad scim-bridge.spec
//
BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Requires:	scim scim-qtimm
BuildRequires:	scim-devel
//

I checked them on Mandriva Cooker. I can't test your package on FC5 now.


Comment 2 Jens Petersen 2006-05-10 22:10:03 UTC
Utumi-san, thanks for your comments.

(In reply to comment #1)
> 1. scim-bridge-0.1.7 is released.
> It's there.
> http://sourceforge.net/project/showfiles.php?group_id=108454&package_id=185651

Thanks for the reminder.

> 2. Source1 doesn't have entries for QT_IM_MODULE and XMODIFIERS.
> $ leafpad xinput-scim-bridge
> //
> GTK_IM_MODULE=scim-bridge
> + QT_IM_MODULE=scim
> + XMODIFIERS=@im=SCIM
> //

This is intentional since those are taken care of by the scim xinput file.

> 3. scim-bridge doesn't lead scim and scim-qtimm.
> We need to add some Requires.
> $ leafpad scim-bridge.spec
> //
> BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> + Requires:	scim scim-qtimm
> BuildRequires:	scim-devel
> //

Ok, I'm adding requires scim, but I don't think scim-bridge should require
scim-qtimm.


Comment 3 Jens Petersen 2006-05-15 11:00:34 UTC
[hmm thought I already posted this here:]

http://people.redhat.com/petersen/extras/scim-bridge-0.1.7-1.src.rpm

Comment 5 Warren Togami 2006-05-22 17:10:02 UTC
It has a few bugs, but the package itself is fine.

APPROVED.  Don't forget to toggle the C++ boolean before building in FC-5. 
After branching, remove all files from the devel directory and add a
dead.package file. 

Comment 6 Jens Petersen 2006-05-30 07:54:32 UTC
Thanks.  FE devel packages built, branches requested, and added to owners list.

Comment 7 Jens Petersen 2006-06-02 03:26:38 UTC
FE4 and FE5 packages have also been built.