Bug 190396

Blockers:
netpanzer non-standard-group Games and Entertainment
Please also include the COPYING file as %doc, as required by the packaging
guidelines.

Suggestions:
I'd suggest changing the Requires: netpanzer-data to netpanzer-data = %{version}
That way, you will not have to update the -data file, when you rebuild the
executable, thus saving bandwidth.
Right now, it is depending by default on netpanzer-data = %{version}-%{release}.

The netpanzer.xpm file is probably unnecessary, especially as the .png file is
referring to the .png file.

Good:
 * proper naming
 * spec file name matches %{name}
 * package meets packaging guidelines
 X License is GPL, License meets packaged COPYING
 * Spec file written in American English
 * Spec file is understandable
 * Package succesfully builds in mock on devel x86_64 and FC-5 x86
 * No locales/shared libraries to worry about
 * No static/libtool files
 * Package not relocatable
 * Package owns all directories it creates
 * No duplicate files
 * Proper file permissions, proper %defattr(...) in spec file
 * Package contains code
 * No need for separate doc package
 * %doc files not needed for runtime
 * No header/other devel package files to worry about
 * Desktop File included and conforming to the desktop file packaging standard

Updated package:

Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/netpanzer.spec
SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/netpanzer-0.8-2.src.rpm

Changes: 

- Changed Package's RPM Group
- Fixed Changelog entries to specify versions
- Stripped '\r' EOL from RELNOTES file
- Added COPYING file

Thanks for updating the package with my suggestions as well as the other
suggestions on IRC.
Gonna take a look at the package tomorrow though.

Looking good. The License is included, The Group is fixed and rpmlint is clean.

APROVED.

However, you'll still need someone to sponsor your account. I can't do it. Sorry.

I can sponsor and you seem worthy of sponsering concedering your quick and
correct reactions to this review and your other opensource and Fedora
(translation / writing) work.

Dropping this back to FE-REVIEW and assigning to me. I'll do a quick Re-review
just to make sure.

Looking good, the icon installation however is not according to the
freedesktop.org standard.

Please mv netpanzer.png to:
$RPM_BUILD_ROOT%{_datadir}/icons/hicolor/48x48/apps
at the end of %install and update %files accordingly.

You should then also add the following scripts to update the icon cache:
%post
touch --no-create %{_datadir}/icons/hicolor || : 
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

These script are described in:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d

Updated package:

Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/netpanzer.spec
SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/netpanzer-0.8-3.src.rpm

Changes: 

- Changed netpanzer.png to comply with freedesktop.org standards.
- Added scripts to update the icon cache after installing

Notes:

Thanks for the support Hans de Goede. I updated the packages with your notes
from Comment #6. I now know about the freedesktop standard :-) If you have any
notes, just say and I'll update it.

Looking good -> Approved!

Go create yourself an account as described here:
http://fedoraproject.org/wiki/Extras/Contributors#head-a89c07b5b8abe7748b6b39f0f89768d595234907

Follow all the steps there, don't forget signing the CLA! (or other steps) once
thats done I'll get a mail that you're awaiting sponsorship and I'll sponsor you.

While waiting for me sponsoring you you can install the client-side plague
(thats the FE buildsystem) tools and setup your CVS environment variables. These
are the next steps as described on:
http://fedoraproject.org/wiki/Extras/Contributors

After that import your package, tag it and request your first build :)
Don't be alarmed if the build fails with some missing gcc deps, rawhide and thus
the devel tree (where are initial imports are done) is broken atm.

Once your build has succeeded don't forget to close this bug with a resolution
of nextrelease.

Hi Hans,

I already have an account in Fedora Accounts System. My username is 'eitch' and
I joined the 'cvsextras' group. Thanks for the support :)

I've just sponsored you, you should have CVS access now, but don't know how long
it takes for the system to pick this up.

This package is now built for FC-4 and FC-5. Closing bug. Thanks for all the
support on my first package guys :)

Don't forget to build it for devel once building there is possible again and
concider adding it to comps/comps-fe5.xml.in (cvs co comps) to make it show up
in pirut.

Change owner to limb (orphaned)

Add lxtnow as co-maintainer.