Bug 1904947
| Summary: | ISO domain images list is empty when virtio-win is not installed on the engine side. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Nisim Simsolo <nsimsolo> | ||||
| Component: | BLL.Virt | Assignee: | Liran Rotenberg <lrotenbe> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nikolai Sednev <nsednev> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | --- | CC: | ahadas, bugs, juzhou, nsednev, nsimsolo | ||||
| Target Milestone: | ovirt-4.4.4 | Keywords: | Triaged | ||||
| Target Release: | 4.4.4.4 | Flags: | pm-rhel:
ovirt-4.4+
pm-rhel: planning_ack+ ahadas: devel_ack+ pm-rhel: testing_ack+ |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ovirt-engine-4.4.4.4 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Previously, when having a windows VM in a cluster equal or above 4.4 and ISO domain without VirtIO-Win RPM installed on the engine, NullPointerException was risen, preventing ISO domain functionality. Now, the engine will handle the case of not having the RPM installed, allowing ISO domain to work as expected.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2021-01-12 16:23:49 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nisim Simsolo
2020-12-07 07:30:25 UTC
Created attachment 1737210 [details]
engine.log
For the record, the exception was:
[org.ovirt.engine.core.bll.storage.repoimage.GetImagesListByStoragePoolIdQuery] (default task-101) [fd57602c-b1a0-4343-b818-6fbc4b5f7447] Exception: java.lang.NullPointerException
at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.storage.repoimage.GetImagesListByStoragePoolIdQuery.executeQueryCommand(GetImagesListByStoragePoolIdQuery.java:39)
at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.QueriesCommandBase.executeCommand(QueriesCommandBase.java:106)
at org.ovirt.engine.core.dal//org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:31)
at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.executor.DefaultBackendQueryExecutor.execute(DefaultBackendQueryExecutor.java:14)
at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runQueryImpl(Backend.java:512)
at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runQuery(Backend.java:481)
And the solution was to install 'virtio-win' on the engine host The problem is that when we have VMs set with windows type and we are in cluster >= 4.4, we support the new virtio-win RPM. Once there is no virtio-win installed, the values of the available virtio-win ISO and the current version of available agent to that OS is null. The engine never checked for null and once we hit the above criteria, we will get NPE on later logic. Proper handling should be added for this case. Works fine with rhvm-4.4.4.5-0.10.el8ev.noarch. ISO images shown fine and available through the list without virtio-win installed on the engine. Moving to verified. rhvm-4.4.4.5-0.10.el8ev.noarch ovirt-hosted-engine-ha-2.4.5-1.el8ev.noarch ovirt-hosted-engine-setup-2.4.9-2.el8ev.noarch Linux 4.18.0-240.10.1.el8_3.x86_64 #1 SMP Wed Dec 16 03:30:52 EST 2020 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux release 8.3 (Ootpa) This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |