Description of problem: After engine update from 4.4.4-2 to 4.4.4-5 the ISO domain images list was empty. installing virtio-win on the engine side solved this issue. Version-Release number of selected component (if applicable): ovirt-engine-4.4.4.3-0.5.el8ev vdsm-4.40.39-1.el8ev.x86_64 qemu-kvm-5.1.0-14.module+el8.3.0+8790+80f9c6d8.1.x86_64 libvirt-daemon-6.6.0-7.1.module+el8.3.0+8852+b44fca9f.x86_64 virtio-win-1.9.14-4.el8.noarch How reproducible: not sure Steps to Reproduce: 1. Update engine 2. Browse WebAdmin -> storage -> ISO domain -> images 3. Actual results: images list is empty if virtio-win is not installed on the engine side. Expected results: ISO domain images list should not be empty. Additional info: engine.log attached, engine was updated at 2020-12-06 10:31:21
Created attachment 1737210 [details] engine.log
For the record, the exception was: [org.ovirt.engine.core.bll.storage.repoimage.GetImagesListByStoragePoolIdQuery] (default task-101) [fd57602c-b1a0-4343-b818-6fbc4b5f7447] Exception: java.lang.NullPointerException at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.storage.repoimage.GetImagesListByStoragePoolIdQuery.executeQueryCommand(GetImagesListByStoragePoolIdQuery.java:39) at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.QueriesCommandBase.executeCommand(QueriesCommandBase.java:106) at org.ovirt.engine.core.dal//org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:31) at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.executor.DefaultBackendQueryExecutor.execute(DefaultBackendQueryExecutor.java:14) at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runQueryImpl(Backend.java:512) at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runQuery(Backend.java:481)
And the solution was to install 'virtio-win' on the engine host
The problem is that when we have VMs set with windows type and we are in cluster >= 4.4, we support the new virtio-win RPM. Once there is no virtio-win installed, the values of the available virtio-win ISO and the current version of available agent to that OS is null. The engine never checked for null and once we hit the above criteria, we will get NPE on later logic. Proper handling should be added for this case.
Works fine with rhvm-4.4.4.5-0.10.el8ev.noarch. ISO images shown fine and available through the list without virtio-win installed on the engine. Moving to verified. rhvm-4.4.4.5-0.10.el8ev.noarch ovirt-hosted-engine-ha-2.4.5-1.el8ev.noarch ovirt-hosted-engine-setup-2.4.9-2.el8ev.noarch Linux 4.18.0-240.10.1.el8_3.x86_64 #1 SMP Wed Dec 16 03:30:52 EST 2020 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux release 8.3 (Ootpa)
This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.