Bug 1906117

Summary:	python3-qdarkstyle should not requires stuff only used as build dependencies
Product:	[Fedora] Fedora	Reporter:	Timothy Redaelli <tredaelli>
Component:	python-qdarkstyle	Assignee:	Mukundan Ragavan <nonamedotc>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	33	CC:	nonamedotc
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-30 17:23:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1785982

Description Timothy Redaelli 2020-12-09 17:19:19 UTC

Currently python3-qdarkstyle requires (explicit requires) lots of python stuff,
but most of them are only required for testing and so they should be only in BuildRequires.

Moreover the the Requires: lines should not be necessary since rpm includes a smart way to detect dependencies.

In your spec file you manually specify the following:

Requires:       python3dist(helpdev) >= 0.6.2
Requires:       python3dist(m2r)
Requires:       python3dist(pyqt5)
Requires:       python3dist(pyside2)
Requires:       python3dist(qtpy) >= 1.7
Requires:       python3dist(qtsass)
Requires:       python3dist(setuptools)
Requires:       python3dist(sphinx)
Requires:       python3dist(sphinx-rtd-theme)
Requires:       python3dist(watchdog)
Requires:       python3dist(tox)

but sphinx, watchdog and tox are only necessary as BuildRequires (tox installs all the python versions fedora has, including pypy and this is not what an user expect).

I don't know which of the remaining Requires are needed, but surely python3dist(helpdev), python3.9dist(qtpy) and python3.9dist(setuptools) are not needed since they are automatically added by rpm:

python3.9dist(helpdev) >= 0.6.10
python3.9dist(qtpy) >= 1.9
python3.9dist(setuptools)

So I suggest to try without any manual "Requires:" and see if it works for you.
You can check the automatic requirements with:
rpm -qRp results_python-qdarkstyle/2.8.1/1.fc33/python3-qdarkstyle-2.8.1-1.fc33.noarch.rpm

Comment 1 Mukundan Ragavan 2020-12-10 10:50:40 UTC

Thanks for the report. I will fix this as soon as I can.

Comment 2 Ben Cotton 2021-11-04 16:49:29 UTC

This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2021-11-30 17:23:32 UTC

Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.