Bug 1907415

Summary:	Role in controller is still 'cam'
Product:	Migration Toolkit for Containers	Reporter:	Jason Montleon <jmontleo>
Component:	Controller	Assignee:	Jason Montleon <jmontleo>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	unspecified	Docs Contact:	Avital Pinnick <apinnick>
Priority:	unspecified
Version:	1.4.0	CC:	ernelson, rjohnson, sregidor
Target Milestone:	---
Target Release:	1.4.0
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/konveyor/mig-controller/pull/858
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-11 12:54:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1894293

Description Jason Montleon 2020-12-14 13:27:43 UTC

Description of problem:
WHile working on updating the controller container name for 1894293 I noticed the Role is still set to CAM as well.

https://github.com/konveyor/mig-controller/blob/9506375bba0e166bc1be43a0ab07862c75eecd7b/pkg/settings/settings.go#L18

Version-Release number of selected component (if applicable):
1.3.2 / 1.4.0

How reproducible:
Always

Steps to Reproduce:
1. oc get deployment -o yaml migration-controller
2. Look at the cam container ROLE env var.

Actual results:
It is currently 'cam'.

Expected results:
It should be updated to 'mtc'.

Additional info:

Comment 4 Sergio 2020-12-22 10:43:16 UTC

Verified using MTC 1.4.0

openshift-migration-rhel7-operator@sha256:236d5f964061938f4e845e6d9e62926da68435c0f0304329a0473e060cdb53f1

    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 5671667a75e12cd538a34c208bfb076534296cdf91f7e97ef48fc59f8ce3c172



$ oc get deployment -o yaml migration-controller | grep "name: ROLE" -A 2
        - name: ROLE
          value: mtc
        - name: SECRET_NAME
--
        - name: ROLE
          value: discovery
        - name: SECRET_NAME

Comment 6 errata-xmlrpc 2021-02-11 12:54:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329