Description of problem: The controller's container name is 'cam' and not 'mtc'. $ oc logs migration-controller-65fcc9bfd-btgrt Error from server (BadRequest): a container name must be specified for pod migration-controller-65fcc9bfd-btgrt, choose one of: [cam discovery] Version: Seen in MTC 1.3.1 and looks to present still in upstream github https://github.com/konveyor/mig-operator/blob/master/roles/migrationcontroller/templates/controller.yml.j2#L106
I'll take a look at this Monday. I am concerned that if we do this we're going to end up with a cam and mtc container on upgrade. If that's the case we'll have to add some additional logic to handle that situation.
As expected this resulted in an mtc and cam container on upgrade. I added some logic to detect the old 'cam' container and delete the deployment before recreating it in case it exists.
Verified using MTC 1.4.0 openshift-migration-rhel7-operator@sha256:236d5f964061938f4e845e6d9e62926da68435c0f0304329a0473e060cdb53f1 - name: MIG_CONTROLLER_REPO value: openshift-migration-controller-rhel8@sha256 - name: MIG_CONTROLLER_TAG value: 5671667a75e12cd538a34c208bfb076534296cdf91f7e97ef48fc59f8ce3c172 $ oc logs migration-controller-f7999c7fd-chzpm error: a container name must be specified for pod migration-controller-f7999c7fd-chzpm, choose one of: [mtc discovery]
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:5329