Bug 1907435
| Summary: | python-holidays fails to build with Python 3.10: TypeError: cannot unpack non-iterable float object | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | python-holidays | Assignee: | Orphan Owner <extras-orphan> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mail, mhroncok, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-06-17 23:05:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1890881 | ||
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34. This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component. This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.
The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.
You can either build the package in the side tag, with:
$ fedpkg build --target=f35-python
Or you can the build and we will eventually build it for you.
Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.
Thanks.
See also https://fedoraproject.org/wiki/Changes/Python3.10
If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build. Automation has figured out the package is retired in rawhide. If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement |
python-holidays fails to build with Python 3.10.0a3. =================================== FAILURES =================================== _______________________ TestIsrael.test_independence_day _______________________ self = <tests.TestIsrael testMethod=test_independence_day> def test_independence_day(self): > self._test_observed_holidays('Independence Day') tests.py:6119: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests.py:6125: in _test_observed_holidays il_holidays = holidays.IL(years=[2017], observed=True) holidays/countries/israel.py:25: in __init__ HolidayBase.__init__(self, **kwargs) holidays/holiday_base.py:34: in __init__ self._populate(year) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = {}, year = 2017 def _populate(self, year): is_leap_year = hebrew.leap(year + hebrew.HEBREW_YEAR_OFFSET) # Passover name = "Passover I" > year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.NISAN, 14) E TypeError: cannot unpack non-iterable float object holidays/countries/israel.py:32: TypeError _________________________ TestIsrael.test_memorial_day _________________________ self = <tests.TestIsrael testMethod=test_memorial_day> def test_memorial_day(self): > self._test_observed_holidays('Memorial Day') tests.py:6116: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests.py:6125: in _test_observed_holidays il_holidays = holidays.IL(years=[2017], observed=True) holidays/countries/israel.py:25: in __init__ HolidayBase.__init__(self, **kwargs) holidays/holiday_base.py:34: in __init__ self._populate(year) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = {}, year = 2017 def _populate(self, year): is_leap_year = hebrew.leap(year + hebrew.HEBREW_YEAR_OFFSET) # Passover name = "Passover I" > year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.NISAN, 14) E TypeError: cannot unpack non-iterable float object holidays/countries/israel.py:32: TypeError =============================== warnings summary =============================== tests.py: 24 warnings /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: Islamic Holidays estimated using 'convertdate' package. tests.py: 24 warnings /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: For higher precision, install 'hijri-converter' package: pip install -U hijri-converter tests.py: 24 warnings /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: (see https://hijri-converter.readthedocs.io/ ) -- Docs: https://docs.pytest.org/en/stable/warnings.html =========================== short test summary info ============================ FAILED tests.py::TestIsrael::test_independence_day - TypeError: cannot unpack... FAILED tests.py::TestIsrael::test_memorial_day - TypeError: cannot unpack non... ================= 2 failed, 572 passed, 72 warnings in 36.68s ================== For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01826883-python-holidays/ For all our attempts to build python-holidays with Python 3.10, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-holidays/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/ Let us know here if you have any questions. Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.