Bug 1907435 - python-holidays fails to build with Python 3.10: TypeError: cannot unpack non-iterable float object
Summary: python-holidays fails to build with Python 3.10: TypeError: cannot unpack non...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: python-holidays
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2020-12-14 14:05 UTC by Tomáš Hrnčiar
Modified: 2021-02-09 16:24 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2020-12-14 14:05:48 UTC
python-holidays fails to build with Python 3.10.0a3.

=================================== FAILURES ===================================
_______________________ TestIsrael.test_independence_day _______________________

self = <tests.TestIsrael testMethod=test_independence_day>

    def test_independence_day(self):
>       self._test_observed_holidays('Independence Day')

tests.py:6119: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests.py:6125: in _test_observed_holidays
    il_holidays = holidays.IL(years=[2017], observed=True)
holidays/countries/israel.py:25: in __init__
    HolidayBase.__init__(self, **kwargs)
holidays/holiday_base.py:34: in __init__
    self._populate(year)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = {}, year = 2017

    def _populate(self, year):
        is_leap_year = hebrew.leap(year + hebrew.HEBREW_YEAR_OFFSET)
    
        # Passover
        name = "Passover I"
>       year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.NISAN, 14)
E       TypeError: cannot unpack non-iterable float object

holidays/countries/israel.py:32: TypeError
_________________________ TestIsrael.test_memorial_day _________________________

self = <tests.TestIsrael testMethod=test_memorial_day>

    def test_memorial_day(self):
>       self._test_observed_holidays('Memorial Day')

tests.py:6116: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests.py:6125: in _test_observed_holidays
    il_holidays = holidays.IL(years=[2017], observed=True)
holidays/countries/israel.py:25: in __init__
    HolidayBase.__init__(self, **kwargs)
holidays/holiday_base.py:34: in __init__
    self._populate(year)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = {}, year = 2017

    def _populate(self, year):
        is_leap_year = hebrew.leap(year + hebrew.HEBREW_YEAR_OFFSET)
    
        # Passover
        name = "Passover I"
>       year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.NISAN, 14)
E       TypeError: cannot unpack non-iterable float object

holidays/countries/israel.py:32: TypeError
=============================== warnings summary ===============================
tests.py: 24 warnings
  /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: Islamic Holidays estimated using 'convertdate' package.

tests.py: 24 warnings
  /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: For higher precision, install 'hijri-converter' package: pip install -U hijri-converter

tests.py: 24 warnings
  /builddir/build/BUILD/python-holidays-0.10.4/holidays/utils.py: (see https://hijri-converter.readthedocs.io/ )

-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info ============================
FAILED tests.py::TestIsrael::test_independence_day - TypeError: cannot unpack...
FAILED tests.py::TestIsrael::test_memorial_day - TypeError: cannot unpack non...
================= 2 failed, 572 passed, 72 warnings in 36.68s ==================

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01826883-python-holidays/

For all our attempts to build python-holidays with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-holidays/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 15:34:12 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.


Note You need to log in before you can comment on or make changes to this bug.