Bug 1908041

Summary: Review Request: juniversalchardet - Java character encoding detection
Product: [Fedora] Fedora Reporter: Jerry James <loganjerry>
Component: Package ReviewAssignee: Sandro Mani <manisandro>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: manisandro, package-review
Target Milestone: ---Flags: manisandro: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-25 11:35:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jerry James 2020-12-15 18:02:19 UTC
Spec URL: https://jjames.fedorapeople.org/juniversalchardet/juniversalchardet.spec
SRPM URL: https://jjames.fedorapeople.org/juniversalchardet/juniversalchardet-2.4.0-1.fc34.src.rpm
Fedora Account System Username: jjames
Description: Juniversalchardet is a Java port of universalchardet, that is, the encoding detector library of Mozilla.

Comment 1 Sandro Mani 2020-12-17 15:51:39 UTC
License is correct.
Requires and provides look good.
Rpmlint only reports a spelling warning which is a false positive.
Criteria listed in [1] are satisfied.
File and directory package ownership is correct.
Nothing jumps to the eye in the build log.

Approved!


[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/

Comment 2 Jerry James 2020-12-17 21:06:56 UTC
Thank you for the review!