Bug 1908041 - Review Request: juniversalchardet - Java character encoding detection
Summary: Review Request: juniversalchardet - Java character encoding detection
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-15 18:02 UTC by Jerry James
Modified: 2020-12-25 11:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-25 11:35:52 UTC
Type: ---
Embargoed:
manisandro: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2020-12-15 18:02:19 UTC
Spec URL: https://jjames.fedorapeople.org/juniversalchardet/juniversalchardet.spec
SRPM URL: https://jjames.fedorapeople.org/juniversalchardet/juniversalchardet-2.4.0-1.fc34.src.rpm
Fedora Account System Username: jjames
Description: Juniversalchardet is a Java port of universalchardet, that is, the encoding detector library of Mozilla.

Comment 1 Sandro Mani 2020-12-17 15:51:39 UTC
License is correct.
Requires and provides look good.
Rpmlint only reports a spelling warning which is a false positive.
Criteria listed in [1] are satisfied.
File and directory package ownership is correct.
Nothing jumps to the eye in the build log.

Approved!


[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/

Comment 2 Jerry James 2020-12-17 21:06:56 UTC
Thank you for the review!


Note You need to log in before you can comment on or make changes to this bug.