Bug 1911002

Summary:	Review Request: R-zip - Cross-Platform 'zip' Compression
Product:	[Fedora] Fedora	Reporter:	Elliott Sales de Andrade <quantum.analyst>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jamatos, package-review
Target Milestone:	---	Flags:	jamatos: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	R-zip-2.1.1-1.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-31 06:13:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1911012

Description Elliott Sales de Andrade 2020-12-26 21:20:23 UTC

Spec URL: https://qulogic.fedorapeople.org/reviews/R-zip/R-zip.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-zip/R-zip-2.1.1-1.fc33.src.rpm

Description:
Cross-Platform 'zip' Compression Library. A replacement for the 'zip'
function, that does not require any additional external tools on any
platform.

Comment 1 Elliott Sales de Andrade 2020-12-26 21:20:43 UTC

koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=58319591

Comment 2 José Matos 2020-12-28 23:10:20 UTC

The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :doc, DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Those are non-issues for reasons detailed in other reviews.

So the package is approved.

Comment 3 Elliott Sales de Andrade 2020-12-28 23:52:56 UTC

Thank you for the review, José

https://pagure.io/releng/fedora-scm-requests/issue/31487

Comment 4 Gwyn Ciesla 2020-12-29 15:46:06 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-zip