Bug 1911002 - Review Request: R-zip - Cross-Platform 'zip' Compression
Summary: Review Request: R-zip - Cross-Platform 'zip' Compression
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1911012
TreeView+ depends on / blocked
 
Reported: 2020-12-26 21:20 UTC by Elliott Sales de Andrade
Modified: 2020-12-31 06:13 UTC (History)
2 users (show)

Fixed In Version: R-zip-2.1.1-1.fc34
Clone Of:
Environment:
Last Closed: 2020-12-31 06:13:19 UTC
Type: ---
Embargoed:
jamatos: fedora-review+

Attachments (Terms of Use)

Description Elliott Sales de Andrade 2020-12-26 21:20:23 UTC 
Spec URL: https://qulogic.fedorapeople.org/reviews/R-zip/R-zip.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-zip/R-zip-2.1.1-1.fc33.src.rpm

Description:
Cross-Platform 'zip' Compression Library. A replacement for the 'zip'
function, that does not require any additional external tools on any
platform.
Comment 1 Elliott Sales de Andrade 2020-12-26 21:20:43 UTC 
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=58319591
Comment 2 José Matos 2020-12-28 23:10:20 UTC 
The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :doc, DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Those are non-issues for reasons detailed in other reviews.

So the package is approved.
Comment 3 Elliott Sales de Andrade 2020-12-28 23:52:56 UTC 
Thank you for the review, José

https://pagure.io/releng/fedora-scm-requests/issue/31487
Comment 4 Gwyn Ciesla 2020-12-29 15:46:06 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-zip
Note You need to log in before you can comment on or make changes to this bug.