Bug 1911012

Summary:	Review Request: R-gert - Simple Git Client for R
Product:	[Fedora] Fedora	Reporter:	Elliott Sales de Andrade <quantum.analyst>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jamatos, package-review
Target Milestone:	---	Flags:	jamatos: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	R-gert-1.0.2-1.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-31 06:32:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1907019, 1911002
Bug Blocks:	1906351

Description Elliott Sales de Andrade 2020-12-26 23:54:30 UTC

Spec URL: https://qulogic.fedorapeople.org/reviews/R-gert/R-gert.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-gert/R-gert-1.0.2-1.fc33.src.rpm

Description:
Simple git client for R based on 'libgit2' with support for SSH and HTTPS
remotes. All functions in 'gert' use basic R data types (such as vectors
and data-frames) for their arguments and return values. User credentials
are shared with command line 'git' through the git-credential store and ssh
keys stored on disk or ssh-agent.

Comment 1 José Matos 2020-12-28 23:26:44 UTC

The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Let us agree to disagree. :-)

The package is approved.

Comment 2 Elliott Sales de Andrade 2020-12-28 23:53:09 UTC

Thank you for the review, José

https://pagure.io/releng/fedora-scm-requests/issue/31488

Comment 3 Gwyn Ciesla 2020-12-29 15:46:27 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-gert