Bug 1911657

Summary:	[machines] 'Changes will take effect after shutting down the VM' notification still exist after change Network to "Direct attachment" and re-run the vm
Product:	Red Hat Enterprise Linux 8	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-appstream	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.4	CC:	wshi, ymao
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-18 15:53:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2020-12-30 14:50:45 UTC

Description of problem: 
 'Changes will take effect after shutting down the VM' notification still exist after change Network to "Direct attachment" and re-run the vm 

Version-Release number of selected component (if applicable):
cockpit-machines-234-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running VM

2. Enter the VM sub page, on 'Network ' tab, click "Edit" of the existing network interface

Change Interface Type to "Direct attachment", then click 'Save'

There is a notification when make changes :"Changes will take effect after shutting down the VM"

3. Shut off and re run the VM

4. Click "Edit" again of the existing network interface

 
Actual results:
There should no notification before make any changes in step 4



Expected results:
And after reboot, the notification should disappear unless you make changes again.

Additional info:

Comment 1 Katerina Koukiou 2021-01-22 12:40:22 UTC

I sent a fix upstream https://github.com/cockpit-project/cockpit/pull/15202

Comment 2 Xianghua Chen 2021-02-05 11:21:36 UTC

Pre verified with package:
cockpit-machines-237-1.el8.noarch

Steps :
1. Prepare a running VM

2. Enter the VM sub page, on 'Network ' tab, click "Edit" of the existing network interface

Change Interface Type to "Direct attachment", then click 'Save'

There is a notification when make changes :"Changes will take effect after shutting down the VM"

3. Shut off and re run the VM

4. Click "Edit" again of the existing network interface

The notification disappear unless you make changes again.
So pre-verified.

Comment 5 Xianghua Chen 2021-02-08 07:36:57 UTC

Verified with package:
cockpit-machines-237-1.el8.noarch

Steps :
1. Prepare a running VM

2. Enter the VM sub page, on 'Network ' tab, click "Edit" of the existing network interface

Change Interface Type to "Direct attachment", then click 'Save'

There is a notification when make changes :"Changes will take effect after shutting down the VM"

3. Shut off and re run the VM

4. Click "Edit" again of the existing network interface

The notification disappear unless you make changes again.
So verified.

Comment 7 errata-xmlrpc 2021-05-18 15:53:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1875