Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1911657

Summary: [machines] 'Changes will take effect after shutting down the VM' notification still exist after change Network to "Direct attachment" and re-run the vm
Product: Red Hat Enterprise Linux 8 Reporter: Xianghua Chen <xchen>
Component: cockpit-appstreamAssignee: Katerina Koukiou <kkoukiou>
Status: CLOSED ERRATA QA Contact: Xianghua Chen <xchen>
Severity: low Docs Contact:
Priority: unspecified    
Version: 8.4CC: wshi, ymao
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:53:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xianghua Chen 2020-12-30 14:50:45 UTC
Description of problem: 
 'Changes will take effect after shutting down the VM' notification still exist after change Network to "Direct attachment" and re-run the vm 

Version-Release number of selected component (if applicable):
cockpit-machines-234-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running VM

2. Enter the VM sub page, on 'Network ' tab, click "Edit" of the existing network interface

Change Interface Type to "Direct attachment", then click 'Save'

There is a notification when make changes :"Changes will take effect after shutting down the VM"

3. Shut off and re run the VM

4. Click "Edit" again of the existing network interface

 
Actual results:
There should no notification before make any changes in step 4



Expected results:
And after reboot, the notification should disappear unless you make changes again.

Additional info:

Comment 1 Katerina Koukiou 2021-01-22 12:40:22 UTC
I sent a fix upstream https://github.com/cockpit-project/cockpit/pull/15202

Comment 2 Xianghua Chen 2021-02-05 11:21:36 UTC
Pre verified with package:
cockpit-machines-237-1.el8.noarch

Steps :
1. Prepare a running VM

2. Enter the VM sub page, on 'Network ' tab, click "Edit" of the existing network interface

Change Interface Type to "Direct attachment", then click 'Save'

There is a notification when make changes :"Changes will take effect after shutting down the VM"

3. Shut off and re run the VM

4. Click "Edit" again of the existing network interface

The notification disappear unless you make changes again.
So pre-verified.

Comment 5 Xianghua Chen 2021-02-08 07:36:57 UTC
Verified with package:
cockpit-machines-237-1.el8.noarch

Steps :
1. Prepare a running VM

2. Enter the VM sub page, on 'Network ' tab, click "Edit" of the existing network interface

Change Interface Type to "Direct attachment", then click 'Save'

There is a notification when make changes :"Changes will take effect after shutting down the VM"

3. Shut off and re run the VM

4. Click "Edit" again of the existing network interface

The notification disappear unless you make changes again.
So verified.

Comment 7 errata-xmlrpc 2021-05-18 15:53:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1875