Bug 1914344

Summary: python-SALib fails to build with new pyscaffold
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-SALibAssignee: Ankur Sinha (FranciscoD) <sanjay.ankur>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 35CC: awilliam, mhroncok, neuro-sig, sanjay.ankur, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: python-SALib-1.4.4-1.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-07 19:06:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1969103, 1988265, 2000598    
Bug Blocks: 1868278, 1890881, 1891954, 1927309, 1927313    

Description Miro Hrončok 2021-01-08 15:50:57 UTC
python-SALib fails to build with Python 3.10.0a4 and Python 3.9.1.

https://koschei.fedoraproject.org/package/python-SALib?collection=f34

=================================== FAILURES ===================================
______________________ test_odd_num_levels_raises_warning ______________________
setup_param_file_with_groups = '/tmp/tmpxbszyeho'
    def test_odd_num_levels_raises_warning(setup_param_file_with_groups):
    
        parameter_file = setup_param_file_with_groups
        problem = read_param_file(parameter_file)
        with warnings.catch_warnings(record=True) as w:
            # Cause all warnings to always be triggered.
            warnings.simplefilter("always")
            # Trigger a warning.
            sample(problem, 10, num_levels=3)
            # Verify some things
>           assert len(w) == 1
E           assert 2 == 1
E             +2
E             -1
tests/sample/morris/test_morris.py:52: AssertionError
_______________________ test_even_num_levels_no_warning ________________________
setup_param_file_with_groups = '/tmp/tmpggoum9g4'
    def test_even_num_levels_no_warning(setup_param_file_with_groups):
    
        parameter_file = setup_param_file_with_groups
        problem = read_param_file(parameter_file)
        with warnings.catch_warnings(record=True) as w:
            # Cause all warnings to always be triggered.
            warnings.simplefilter("always")
            # Trigger a warning.
            sample(problem, 10, num_levels=4)
            # Verify some things
>           assert len(w) == 0
E           assert 1 == 0
E             +1
E             -0
tests/sample/morris/test_morris.py:67: AssertionError



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01865244-python-SALib/

For all our attempts to build python-SALib with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-SALib/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Fedora Release Engineering 2021-01-24 04:22:47 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-05).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 2 Ben Cotton 2021-02-09 15:38:51 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 3 Miro Hrončok 2021-06-04 20:15:11 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 4 Miro Hrončok 2021-06-07 22:59:39 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 5 Miro Hrončok 2021-06-08 11:32:48 UTC
*** Bug 1968877 has been marked as a duplicate of this bug. ***

Comment 6 Ankur Sinha (FranciscoD) 2021-06-17 18:51:29 UTC
Currently blocked by pyscaffold FTI

Comment 7 Miro Hrončok 2021-07-07 07:52:58 UTC
Unblocked.

Comment 8 Ben Cotton 2021-08-10 12:50:14 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 9 Miro Hrončok 2021-08-23 12:00:55 UTC
The current failure is:

WARNING: The wheel package is not available.
/usr/bin/python3: No module named pip
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/setuptools/installer.py", line 75, in fetch_build_egg
    subprocess.check_call(cmd)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpw9o0_w7r', '--quiet', 'pyscaffold<3.3a0,>=3.2a0']' returned non-zero exit status 1.

We have pyscaffold 4.

Comment 10 Ankur Sinha (FranciscoD) 2021-08-23 12:23:36 UTC
Yes, the new SALib version works  with pyscaffold 4, but it includes a few new BRs that we are in the process of packaging.

Comment 11 Miro Hrončok 2021-08-30 22:37:03 UTC
Do you need some package reviews to move this forward?

Comment 12 Ankur Sinha (FranciscoD) 2021-08-31 14:49:28 UTC
Yeh, this requires pathos which requires dill, pox, ppft, and multiprocess. We've done pox and ppft, but multiprocess and pathos remain:

https://bugzilla.redhat.com/show_bug.cgi?id=1988265

Comment 13 Fedora Update System 2021-09-03 16:10:31 UTC
FEDORA-2021-5563bc0903 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5563bc0903

Comment 14 Miro Hrončok 2021-09-03 16:25:13 UTC
Requesting a freeze exception as this package does not install without the fix.

Comment 15 Fedora Update System 2021-09-03 16:28:08 UTC
FEDORA-2021-040d0bf6ef has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-040d0bf6ef

Comment 16 Fedora Update System 2021-09-03 16:28:19 UTC
FEDORA-2021-5096400c49 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5096400c49

Comment 17 Miro Hrončok 2021-09-03 16:29:13 UTC
More info for the freeze exception: All three associated updates need to be pushed togteher.

Comment 18 Fedora Update System 2021-09-03 18:05:50 UTC
FEDORA-2021-5563bc0903 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-5563bc0903`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5563bc0903

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Adam Williamson 2021-09-06 15:09:51 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/429 , marking accepted.

Comment 20 Fedora Update System 2021-09-07 19:06:46 UTC
FEDORA-2021-5096400c49 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2021-09-07 19:07:32 UTC
FEDORA-2021-040d0bf6ef has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2021-09-07 19:07:38 UTC
FEDORA-2021-5563bc0903 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.