Bug 1988265 - Review Request: python-multiprocess - Better multiprocessing and multithreading in python
Summary: Review Request: python-multiprocess - Better multiprocessing and multithreadi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1914344
TreeView+ depends on / blocked
 
Reported: 2021-07-30 08:22 UTC by Ankur Sinha (FranciscoD)
Modified: 2021-09-09 17:31 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-09-07 19:06:53 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 2000022 1 unspecified CLOSED /usr/bin/python3: symbol lookup error: /lib64/libpython3.10.so.1.0: undefined symbol: close_range, version GLIBC_2.34 2021-09-01 10:15:16 UTC

Description Ankur Sinha (FranciscoD) 2021-07-30 08:22:30 UTC
Spec URL: https://ankursinha.fedorapeople.org/python-multiprocess/python-multiprocess.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-multiprocess/python-multiprocess-0.70.12.2-1.fc34.src.rpm

Description: 
multiprocess is a fork of multiprocessing, and is developed as part of
pathos: https://github.com/uqfoundation/pathos

multiprocessing is a package for the Python language which supports the
spawning of processes using the API of the standard library’s threading module.
multiprocessing has been distributed in the standard library since python 2.6.

Features:

- Objects can be transferred between processes using pipes or
  multi-producer/multi-consumer queues.
- Objects can be shared between processes using a server process or
  (for simple data) shared memory.
- Equivalents of all the synchronization primitives in threading are
  available.
- A Pool class makes it easy to submit tasks to a pool of worker
  processes.

multiprocess is part of pathos, a python framework for heterogeneous
computing. multiprocess is in active development, so any user feedback,
bug reports, comments, or suggestions are highly appreciated. A list of
issues is located at
https://github.com/uqfoundation/multiprocess/issues, with a legacy list
maintained at https://uqfoundation.github.io/project/pathos/query.

Fedora Account System Username: ankursinha

Comment 1 Zbigniew Jędrzejewski-Szmek 2021-09-01 08:16:29 UTC
Hmm, mock build fails here with:
+ find py/doc/ -name '*' -exec sed -i 's/\r$//' '{}' ';'
find: 'py/doc/': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.OGZ8U7 (%prep)

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-09-01 08:18:22 UTC
<mock-chroot> sh-5.1# rpmbuild  --eval '%{python3_version}'
/usr/bin/python3: symbol lookup error: /lib64/libpython3.10.so.1.0: undefined symbol: close_range, version GLIBC_2.34

Yikes!

Comment 3 Zbigniew Jędrzejewski-Szmek 2021-09-01 08:57:14 UTC
I managed to file a bug against python3, and close it, since it seems like some local issue.

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and installs OK
+ %check is present and passes
+ BR/P/R look OK
+ fedora-review complains a bit, but I don't think any of this is relevant:

Issues:
=======
- Packages MUST NOT have dependencies (either build-time or runtime) on
  packages named with the unversioned python- prefix unless no properly
  versioned package exists. Dependencies on Python packages instead MUST
  use names beginning with python2- or python3- as appropriate.
  Note: Unversionned Python dependency found.
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies

Maybe this is about the dependency on python-unversioned-command? The guidelines
don't actually say that this is not allowed. Seems fine to me.

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING.html is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

COPYING is included instead.

+ rpmlint also has only false positives about spelling.

Package is APPROVED.

Comment 4 Ankur Sinha (FranciscoD) 2021-09-01 10:13:15 UTC
Thanks very much, requested SCM now:

https://pagure.io/releng/fedora-scm-requests/issue/36650

Comment 5 Tomas Hrcka 2021-09-01 10:13:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-multiprocess

Comment 6 Fedora Update System 2021-09-01 10:44:54 UTC
FEDORA-2021-3548e74b0d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3548e74b0d

Comment 7 Fedora Update System 2021-09-01 10:44:55 UTC
FEDORA-2021-5096400c49 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5096400c49

Comment 8 Fedora Update System 2021-09-01 19:26:53 UTC
FEDORA-2021-5096400c49 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5096400c49 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5096400c49

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-09-01 20:20:17 UTC
FEDORA-2021-3548e74b0d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-3548e74b0d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3548e74b0d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-09-07 19:06:53 UTC
FEDORA-2021-5096400c49 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2021-09-09 17:31:52 UTC
FEDORA-2021-3548e74b0d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.