Bug 19146

Summary: Authentication failed even with correct password
Product: [Retired] Red Hat Powertools Reporter: Tim Waugh <twaugh>
Component: vncAssignee: Bernhard Rosenkraenzer <bero>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2000-10-15 20:37:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Description Flags
Here's a patch that fixes the problem for me. none

Description Tim Waugh 2000-10-15 20:36:35 UTC
When running vncviewer from an icon on the desktop, sometimes
authentication is refused even though the correct password is entered into
the dialog box.

This seems to be because of constructs such as this:

password = XtNewString(XawDialogGetValueString(dialog));

XawDialogGetValueString frees and reallocates a value to return each time,
and XtNewString is a macro which uses its argument many times, and so if
XawDialogGVS returns a different value on successful calls during the
execution of the expansion of the XtNewString macro, "odd" things happen,
and password ends up pointing to the wrong place.

Comment 1 Tim Waugh 2000-10-15 20:37:49 UTC
Created attachment 4172 [details]
Here's a patch that fixes the problem for me.

Comment 2 Bernhard Rosenkraenzer 2000-10-16 10:08:09 UTC
Thanks, fixed. (Btw: Why don't you just take the vnc package? You're doing much more with it than I am.)

Comment 3 Tim Waugh 2000-10-16 10:14:27 UTC
Ahem.. I thought I had..

Comment 4 Tim Waugh 2000-10-16 10:23:52 UTC
Incidentally, for those that want to check that it really does fix the problem
for them, the fixed package is vnc-3.3.3r1-10.