Bug 1915179

Summary:	postgresql-12.4-3.fc34 FTBFS: dblink test fails: Valid options in this context are: user, password, sslpassword
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	postgresql	Assignee:	Patrik Novotný <panovotn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	34	CC:	anon.amish, devrim, hhorak, jmlich83, mmathesi, panovotn, pkubat, praiskup, tgl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://koschei.fedoraproject.org/package/postgresql
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-10 11:09:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1868278

Description Petr Pisar 2021-01-12 07:25:50 UTC

postgresql-12.4-3.fc34 fails to build in Fedora 34 because a test fails:

make: Target 'check' not remade because of errors.
+ test_failure=1
+ set +x
=== trying to find all regression.diffs files in build directory ===
=== make failure: contrib/dblink/regression.diffs ===
diff -U3 /builddir/build/BUILD/postgresql-12.4/contrib/dblink/expected/dblink.out /builddir/build/BUILD/postgresql-12.4/contrib/dblink/results/dblink.out
--- /builddir/build/BUILD/postgresql-12.4/contrib/dblink/expected/dblink.out	2020-08-10 21:15:53.000000000 +0000
+++ /builddir/build/BUILD/postgresql-12.4/contrib/dblink/results/dblink.out	2021-01-10 23:37:44.138104604 +0000
@@ -879,7 +879,7 @@
 CREATE USER MAPPING FOR public SERVER fdtest
   OPTIONS (server 'localhost');  -- fail, can't specify server here
 ERROR:  invalid option "server"
-HINT:  Valid options in this context are: user, password
+HINT:  Valid options in this context are: user, password, sslpassword
 CREATE USER MAPPING FOR public SERVER fdtest OPTIONS (user :'USER');
 GRANT USAGE ON FOREIGN SERVER fdtest TO regress_dblink_user;
 GRANT EXECUTE ON FUNCTION dblink_connect_u(text, text) TO regress_dblink_user;

A difference between passing and failing build root is at <https://koschei.fedoraproject.org/build/9283778>.

Comment 1 Tom Lane 2021-01-12 14:40:11 UTC

The sslpassword option was introduced in PG13, so a reasonable bet here is that libpq.so from version 13 is being used, but the test case expects the message that version 12's libpq.so would produce.

Comment 2 Merlin Mathesius 2021-01-22 21:21:57 UTC

A fix for this is provided by https://src.fedoraproject.org/rpms/postgresql/pull-request/25

Comment 3 Fedora Release Engineering 2021-01-24 04:22:54 UTC

Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-09).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 4 Ben Cotton 2021-02-09 15:39:45 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 5 Fedora Release Engineering 2021-02-14 04:22:33 UTC

Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-09).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 6 Fedora Release Engineering 2021-03-07 04:22:20 UTC

Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-09).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html