postgresql-12.4-3.fc34 fails to build in Fedora 34 because a test fails: make: Target 'check' not remade because of errors. + test_failure=1 + set +x === trying to find all regression.diffs files in build directory === === make failure: contrib/dblink/regression.diffs === diff -U3 /builddir/build/BUILD/postgresql-12.4/contrib/dblink/expected/dblink.out /builddir/build/BUILD/postgresql-12.4/contrib/dblink/results/dblink.out --- /builddir/build/BUILD/postgresql-12.4/contrib/dblink/expected/dblink.out 2020-08-10 21:15:53.000000000 +0000 +++ /builddir/build/BUILD/postgresql-12.4/contrib/dblink/results/dblink.out 2021-01-10 23:37:44.138104604 +0000 @@ -879,7 +879,7 @@ CREATE USER MAPPING FOR public SERVER fdtest OPTIONS (server 'localhost'); -- fail, can't specify server here ERROR: invalid option "server" -HINT: Valid options in this context are: user, password +HINT: Valid options in this context are: user, password, sslpassword CREATE USER MAPPING FOR public SERVER fdtest OPTIONS (user :'USER'); GRANT USAGE ON FOREIGN SERVER fdtest TO regress_dblink_user; GRANT EXECUTE ON FUNCTION dblink_connect_u(text, text) TO regress_dblink_user; A difference between passing and failing build root is at <https://koschei.fedoraproject.org/build/9283778>.
The sslpassword option was introduced in PG13, so a reasonable bet here is that libpq.so from version 13 is being used, but the test case expects the message that version 12's libpq.so would produce.
A fix for this is provided by https://src.fedoraproject.org/rpms/postgresql/pull-request/25
Dear Maintainer, your package has an open Fails To Build From Source bug for Fedora 34. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. If you have already fixed this issue, please close this Bugzilla report. Following the policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-09). A week before the mass branching of Fedora 35 according to the schedule [3], any packages not successfully rebuilt at least on Fedora 33 will be retired regardless of the status of this bug. [1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34.