Bug 1916144

Summary:	[RFE] Check otopi's dnf package with signatures during CI automation/check-patch.sh
Product:	[oVirt] otopi	Reporter:	Yedidyah Bar David <didi>
Component:	General	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nobody <nobody>
Severity:	low	Docs Contact:
Priority:	low
Version:	master	CC:	bugs
Target Milestone:	ovirt-4.5.0-1	Keywords:	CodeChange, FutureFeature, VerifiedUpstream, ZStream
Target Release:	1.10.0	Flags:	pm-rhel: ovirt-4.5? pm-rhel: planning_ack? pm-rhel: devel_ack+ pm-rhel: testing_ack?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	otopi-1.10.0	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-30 08:31:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2034313

Description Yedidyah Bar David 2021-01-14 10:38:39 UTC

Description of problem:

Copying my comment from https://gerrit.ovirt.org/c/otopi/+/112980 :

If/when we have some time, will be useful to improve this patch to also do a full test - generate keypair, import it to rpm db, sign the packages, install, then remove the packages, remove the key from rpm db (but make it available in the repo in gpgkey), try again to install and see that otopi prompts, asking to import the key (and provide an answer in the answerfile, if needed, to accept).

To clarify - this isn't an RFE for otopi itself, it's just for CI.

Comment 1 Yedidyah Bar David 2022-01-17 09:48:19 UTC

This is a CodeChange. Also without the patch, it was possible to do e.g.:

otopi ODEBUG/packagesAction=str:install ODEBUG/packages=str:somepackage

Where somepackage is a signed package available from some repo having gpgkey pointing to a key not yet imported to the rpm db. otopi correctly prompts confirming importing of the key.

I also merged a patch allowing providing an answer to this confirmation, e.g.:

otopi QUESTION/1/DIALOG_CONFIRM/GPG_KEY=str:yes ODEBUG/packagesAction=str:install ODEBUG/packages=str:somepackage

For a complete demonstration you can see the linked patch.