Bug 1916144 - [RFE] Check otopi's dnf package with signatures during CI automation/check-patch.sh
Summary: [RFE] Check otopi's dnf package with signatures during CI automation/check-pa...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: otopi
Classification: oVirt
Component: General
Version: master
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.5.0-1
: 1.10.0
Assignee: Yedidyah Bar David
QA Contact: Nobody
URL:
Whiteboard:
Depends On:
Blocks: 2034313
TreeView+ depends on / blocked
 
Reported: 2021-01-14 10:38 UTC by Yedidyah Bar David
Modified: 2022-05-30 08:31 UTC (History)
1 user (show)

Fixed In Version: otopi-1.10.0
Clone Of:
Environment:
Last Closed: 2022-05-30 08:31:29 UTC
oVirt Team: Integration
Embargoed:
pm-rhel: ovirt-4.5?
pm-rhel: planning_ack?
pm-rhel: devel_ack+
pm-rhel: testing_ack?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github oVirt otopi pull 13 0 None Merged Dnf verify gpgkey 2022-01-17 09:41:43 UTC
oVirt gerrit 115366 0 master ABANDONED test, do not merge: test 2021-12-05 12:30:35 UTC

Description Yedidyah Bar David 2021-01-14 10:38:39 UTC
Description of problem:

Copying my comment from https://gerrit.ovirt.org/c/otopi/+/112980 :

If/when we have some time, will be useful to improve this patch to also do a full test - generate keypair, import it to rpm db, sign the packages, install, then remove the packages, remove the key from rpm db (but make it available in the repo in gpgkey), try again to install and see that otopi prompts, asking to import the key (and provide an answer in the answerfile, if needed, to accept).

To clarify - this isn't an RFE for otopi itself, it's just for CI.

Comment 1 Yedidyah Bar David 2022-01-17 09:48:19 UTC
This is a CodeChange. Also without the patch, it was possible to do e.g.:

otopi ODEBUG/packagesAction=str:install ODEBUG/packages=str:somepackage

Where somepackage is a signed package available from some repo having gpgkey pointing to a key not yet imported to the rpm db. otopi correctly prompts confirming importing of the key.

I also merged a patch allowing providing an answer to this confirmation, e.g.:

otopi QUESTION/1/DIALOG_CONFIRM/GPG_KEY=str:yes ODEBUG/packagesAction=str:install ODEBUG/packages=str:somepackage

For a complete demonstration you can see the linked patch.


Note You need to log in before you can comment on or make changes to this bug.