Bug 1917266 (qt6)

Summary: Review Request: qt6 - Qt6 meta package
Product: [Fedora] Fedora Reporter: Jan Grulich <jgrulich>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-01-22 16:12:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1917559    

Description Jan Grulich 2021-01-18 08:39:45 UTC 
Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6.spec
SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6-6.0.0-1.fc33.src.rpm
Description: Qt6 meta package
Fedora Account System Username: jgrulich
Comment 1 Neal Gompa 2021-01-18 14:38:28 UTC 
> sed -i \
>  -e "s|@@QT5_CFLAGS@@|%{?qt6_cflags}|g" \
>  -e "s|@@QT5_CXXFLAGS@@|%{?qt6_cxxflags}|g" \
>  -e "s|@@QT5_RPM_LD_FLAGS@@|%{?qt6_rpm_ld_flags}|g" \
>  -e "s|@@QT5_RPM_OPT_FLAGS@@|%{?qt6_rpm_opt_flags}|g" \
>  -e "s|@@QMAKE@@|%{_prefix}/%%{_lib}/qt6/bin/qmake|g" \
>  -e "s|@@QMAKE_QT5_WRAPPER@@|%{_bindir}/qmake-qt6.sh|g" \

Shouldn't these use QT6 instead of QT5?
Comment 2 Neal Gompa 2021-01-18 14:38:47 UTC 
Taking this review.
Comment 3 Neal Gompa 2021-01-18 14:57:54 UTC 
You can also replace "%{_rpmconfigdir}/macros.d" with "%{_rpmmacrodir}" in the spec...
Comment 4 Jan Grulich 2021-01-20 07:17:04 UTC 
Updated package:

Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6.spec
SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6-6.0.0-1.fc33.src.rpm
Description: Qt6 meta package
Fedora Account System Username: jgrulich
Comment 5 Neal Gompa 2021-01-21 11:36:28 UTC 
Review notes:

* Package is named correctly
* Package follows proper conventions for Qt packages
* Package builds and installs (when everything else is available...)
* No serious issues from rpmlint
Comment 6 Gwyn Ciesla 2021-01-21 14:19:23 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6