Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6-6.0.0-1.fc33.src.rpm Description: Qt6 meta package Fedora Account System Username: jgrulich
> sed -i \ > -e "s|@@QT5_CFLAGS@@|%{?qt6_cflags}|g" \ > -e "s|@@QT5_CXXFLAGS@@|%{?qt6_cxxflags}|g" \ > -e "s|@@QT5_RPM_LD_FLAGS@@|%{?qt6_rpm_ld_flags}|g" \ > -e "s|@@QT5_RPM_OPT_FLAGS@@|%{?qt6_rpm_opt_flags}|g" \ > -e "s|@@QMAKE@@|%{_prefix}/%%{_lib}/qt6/bin/qmake|g" \ > -e "s|@@QMAKE_QT5_WRAPPER@@|%{_bindir}/qmake-qt6.sh|g" \ Shouldn't these use QT6 instead of QT5?
Taking this review.
You can also replace "%{_rpmconfigdir}/macros.d" with "%{_rpmmacrodir}" in the spec...
Updated package: Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6-6.0.0-1.fc33.src.rpm Description: Qt6 meta package Fedora Account System Username: jgrulich
Review notes: * Package is named correctly * Package follows proper conventions for Qt packages * Package builds and installs (when everything else is available...) * No serious issues from rpmlint
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6