Bug 1917296 (qt6-qttranslations)
| Summary: | Review Request: qt6-qttranslations - Qt6 - QtTranslations module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-01-22 16:07:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1917559 | ||
|
Description
Jan Grulich
2021-01-18 09:19:45 UTC
Update package: Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qttranslations/qt6-qttranslations.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qttranslations/qt6-qttranslations-6.0.0-1.fc33.src.rpm Description: Qt6 - QtTranslations module Fedora Account System Username: jgrulich Taking this review. Is there a reason you're not using "%find_lang --with-qt" for this? (In reply to Neal Gompa from comment #3) > Is there a reason you're not using "%find_lang --with-qt" for this? I should have kept comments Rex has in qt5-qttranslations: > # not used currently, since we track locales manually to keep %%files/Provides sync'd -- rex > #find_lang qttranslations --all-name --with-qt --without-mo Yeah, the comment explains why we're doing that. :) Review notes: * Package is named correctly * Package follows proper conventions for Qt packages * Package builds and installs (when everything else is available...) * No serious issues from rpmlint (In reply to Neal Gompa from comment #5) > Yeah, the comment explains why we're doing that. :) I'll re-add the comment when submitting the package to dist-git. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qttranslations |