Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qttranslations/qt6-qttranslations.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qttranslations/qt6-qttranslations-6.0.0-1.fc33.src.rpm Description: Qt6 - QtTranslations module Fedora Account System Username: jgrulich
Update package: Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6-qttranslations/qt6-qttranslations.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6-qttranslations/qt6-qttranslations-6.0.0-1.fc33.src.rpm Description: Qt6 - QtTranslations module Fedora Account System Username: jgrulich
Taking this review.
Is there a reason you're not using "%find_lang --with-qt" for this?
(In reply to Neal Gompa from comment #3) > Is there a reason you're not using "%find_lang --with-qt" for this? I should have kept comments Rex has in qt5-qttranslations: > # not used currently, since we track locales manually to keep %%files/Provides sync'd -- rex > #find_lang qttranslations --all-name --with-qt --without-mo
Yeah, the comment explains why we're doing that. :)
Review notes: * Package is named correctly * Package follows proper conventions for Qt packages * Package builds and installs (when everything else is available...) * No serious issues from rpmlint
(In reply to Neal Gompa from comment #5) > Yeah, the comment explains why we're doing that. :) I'll re-add the comment when submitting the package to dist-git.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qttranslations