Bug 1917998
| Summary: | Review Request: oc-inject - Copy an executable to an OpenShift container and run it | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Serhei Makarov <serhei> |
| Component: | Package Review | Assignee: | Frank Ch. Eigler <fche> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fche, package-review |
| Target Milestone: | --- | Flags: | fche:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-02-19 01:13:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Serhei Makarov
2021-01-19 19:34:30 UTC
Fixed Source0 in the spec file and updated URLs in the comment above. New koji build at https://koji.fedoraproject.org/koji/taskinfo?taskID=60105083 Generally looks fine & simple. A few nits: - Source: github url should be corrected - Consider noting the oc dependency (origin-clients or perhaps kubernetes-client) - Consider noting the java related soft dependencies - @JAVA_HOME@ needs to be expanded properly within oc-inject, maybe to an os.environ[] expression? % rpmlint oc-inject-0.7.9-2.fc34.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. % rpmlint oc-inject-0.7.9-2.fc34.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. % mock -r fedora-33-x86_64 --rebuild oc-inject-0.7.9-2.fc34.src.rpm [fine] Built another version of the package.
(The %if 0%{?fedora} is temporary as COPR EPEL builds don't seem to understand 'Recommends'.
I need to decide what to do there, but it's not relevant for Fedora.)
New Spec URL: https://download.copr.fedorainfracloud.org/results/serhei/oc-inject/fedora-rawhide-x86_64/01891060-oc-inject/oc-inject.spec
New SRPM URL: https://download.copr.fedorainfracloud.org/results/serhei/oc-inject/fedora-rawhide-x86_64/01891060-oc-inject/oc-inject-0.7.9-3.fc34.src.rpm
New Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60157863
lgtm fche, Thanks for the review. Setting FE-NEEDSPONSOR since it looks like I do need it to proceed with the next step. Nevermind, I remembered I was previously sponsored for fedora packaging under the 'smakarov' account. Clearing FE-NEEDSPONSOR and editing the username in the original review request. Now if I could only get that account to log into Pagure.... (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oc-inject FEDORA-2021-03687eaf3c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-03687eaf3c FEDORA-2021-03687eaf3c has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-03687eaf3c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-03687eaf3c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-03687eaf3c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |