Spec URL: https://download.copr.fedorainfracloud.org/results/serhei/oc-inject/fedora-rawhide-x86_64/01889778-oc-inject/oc-inject.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/serhei/oc-inject/fedora-rawhide-x86_64/01889778-oc-inject/oc-inject-0.7.9-2.fc34.src.rpm Description: Copy an executable to an OpenShift container and run the executable. oc-inject is a prototype tool for last-resort troubleshooting of a running container, when a required debugging tool is not present in the container image. Fedora Account System Username: smakarov Note: This is my first new package submission for Fedora. I maintain an upstream repo of this project at https://github.com/serhei/oc-inject. Koji scratch build at https://koji.fedoraproject.org/koji/taskinfo?taskID=59983051
Fixed Source0 in the spec file and updated URLs in the comment above. New koji build at https://koji.fedoraproject.org/koji/taskinfo?taskID=60105083
Generally looks fine & simple. A few nits: - Source: github url should be corrected - Consider noting the oc dependency (origin-clients or perhaps kubernetes-client) - Consider noting the java related soft dependencies - @JAVA_HOME@ needs to be expanded properly within oc-inject, maybe to an os.environ[] expression?
% rpmlint oc-inject-0.7.9-2.fc34.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. % rpmlint oc-inject-0.7.9-2.fc34.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. % mock -r fedora-33-x86_64 --rebuild oc-inject-0.7.9-2.fc34.src.rpm [fine]
Built another version of the package. (The %if 0%{?fedora} is temporary as COPR EPEL builds don't seem to understand 'Recommends'. I need to decide what to do there, but it's not relevant for Fedora.) New Spec URL: https://download.copr.fedorainfracloud.org/results/serhei/oc-inject/fedora-rawhide-x86_64/01891060-oc-inject/oc-inject.spec New SRPM URL: https://download.copr.fedorainfracloud.org/results/serhei/oc-inject/fedora-rawhide-x86_64/01891060-oc-inject/oc-inject-0.7.9-3.fc34.src.rpm New Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60157863
lgtm
fche, Thanks for the review. Setting FE-NEEDSPONSOR since it looks like I do need it to proceed with the next step.
Nevermind, I remembered I was previously sponsored for fedora packaging under the 'smakarov' account. Clearing FE-NEEDSPONSOR and editing the username in the original review request. Now if I could only get that account to log into Pagure....
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oc-inject
FEDORA-2021-03687eaf3c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-03687eaf3c
FEDORA-2021-03687eaf3c has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-03687eaf3c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-03687eaf3c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-03687eaf3c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.