Bug 1918111

Summary:	Review Request: bitwarden-cli - Bitwarden vault CLI tool
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Stephen Gallagher <sgallagh>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, sgallagh
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-20 00:45:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Michel Lind 2021-01-20 04:44:51 UTC

Spec URL: https://salimma.fedorapeople.org/specs/nodejs/bitwarden-cli.spec
SRPM URL: https://salimma.fedorapeople.org/specs/nodejs/bitwarden-cli-1.13.3-1.fc33.src.rpm
Description:
The Bitwarden CLI is a powerful, full-featured command-line interface (CLI) tool
to access and manage a Bitwarden vault. The CLI is written with TypeScript and
Node.js

Fedora Account System Username: salimma

Comment 1 Stephen Gallagher 2021-01-20 14:52:52 UTC

warning: Explicit %attr() mode not applicable to symlink: /builddir/build/BUILDROOT/bitwarden-cli-1.13.3-1.fc34.x86_64/usr/bin/bw


I think you can just drop that, since you set the permissions of the linked file in the %install section.

Also please include a comment explaining how you generated the bundled dependencies and licenses.

Other than that, it looks good to me.

Comment 2 Package Review 2021-02-20 00:45:16 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.