Bug 1918111 - Review Request: bitwarden-cli - Bitwarden vault CLI tool
Summary: Review Request: bitwarden-cli - Bitwarden vault CLI tool
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2021-01-20 04:44 UTC by Michel Lind
Modified: 2021-02-20 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-02-20 00:45:16 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michel Lind 2021-01-20 04:44:51 UTC
Spec URL: https://salimma.fedorapeople.org/specs/nodejs/bitwarden-cli.spec
SRPM URL: https://salimma.fedorapeople.org/specs/nodejs/bitwarden-cli-1.13.3-1.fc33.src.rpm
Description:
The Bitwarden CLI is a powerful, full-featured command-line interface (CLI) tool
to access and manage a Bitwarden vault. The CLI is written with TypeScript and
Node.js

Fedora Account System Username: salimma

Comment 1 Stephen Gallagher 2021-01-20 14:52:52 UTC
warning: Explicit %attr() mode not applicable to symlink: /builddir/build/BUILDROOT/bitwarden-cli-1.13.3-1.fc34.x86_64/usr/bin/bw


I think you can just drop that, since you set the permissions of the linked file in the %install section.

Also please include a comment explaining how you generated the bundled dependencies and licenses.

Other than that, it looks good to me.

Comment 2 Package Review 2021-02-20 00:45:16 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.