Bug 1920874
| Summary: | Some changes of qga command "get-devices" should be fix on mingw-qemu-ga-win to qemu 5.2 | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | dehanmeng <demeng> | |
| Component: | virtio-win | Assignee: | Virtualization Maintenance <virt-maint> | |
| virtio-win sub component: | qemu-ga-win | QA Contact: | dehanmeng <demeng> | |
| Status: | CLOSED ERRATA | Docs Contact: | ||
| Severity: | unspecified | |||
| Priority: | unspecified | CC: | ailan, juzhang, lijin, lmiksik, mdean, yvugenfi | |
| Version: | 8.4 | Keywords: | Rebase, Triaged | |
| Target Milestone: | rc | |||
| Target Release: | 8.0 | |||
| Hardware: | Unspecified | |||
| OS: | Windows | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1935249 (view as bug list) | Environment: | ||
| Last Closed: | 2021-05-18 16:25:58 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1915198 | |||
| Bug Blocks: | 1935249 | |||
set ITR to rhel840 and ITM16 according to discussion with basil in mail. thanks Hi Dehan, Scratch build with changes: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=35146591 can this build be verified for this bug too? Thanks in advance, Basil (In reply to Basil Salman from comment #6) > Hi Dehan, > > Scratch build with changes: > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=35146591 > can this build be verified for this bug too? > > Thanks in advance, > Basil Hi Basil, Okay, sure, Will use this new build to check and update result asap. thanks for your effort, Basil. BR Dehan Hi Basil,
qga command {"guest-get-devices"} of new build works well.
reproduce with previous mingw-qemu-ga-win-101.2.0-1.el7ev
step to verify:
1. boot up win2019 guest with serial and qga.
2. connect with guest and execute qga command.
Actual result;
{"execute":"guest-get-devices"}
{"return": [{"driver-date": "2021-02-02", "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19400", "address": {"type": "pci", "data": {"device-id": 4168, "vendor-id": 6900}}}, {"driver-date": "2021-02-02", "driver-name": "Red Hat VirtIO Ethernet Adapter #2", "driver-version": "100.84.104.19400", "address": {"type": "pci", "data": {"device-id": 4161, "vendor-id": 6900}}}, {"driver-date": "2006-06-21", "driver-name": "Microsoft Basic Display Adapter", "driver-version": "10.0.17763.1", "address": {"type": "pci", "data": {"device-id": 4176, "vendor-id": 6900}}}, {"driver-date": "2021-02-02", "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19400", "address": {"type": "pci", "data": {"device-id": 4163, "vendor-id": 6900}}}]}
Expected result:
return devices info of guest successfully.
Verify with this build qemu-ga-win-102.0.0-1.el8.noarch.rpm
step to verify:
1. boot up win2019 guest with serial and qga.
2. connect with guest and execute qga command.
Actually result:
{"execute":"guest-get-devices"}
{"return": [{"driver-date": 1612224000000000000, "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19400", "id": {"device-id": 4168, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1612224000000000000, "driver-name": "Red Hat VirtIO Ethernet Adapter #2", "driver-version": "100.84.104.19400", "id": {"device-id": 4161, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1150848000000000000, "driver-name": "Microsoft Basic Display Adapter", "driver-version": "10.0.17763.1", "id": {"device-id": 4176, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1612224000000000000, "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19400", "id": {"device-id": 4163, "vendor-id": 6900, "type": "pci"}}]}
Expected result:
as above.
Build that resolves this bug: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=35297151 reproduce with previous mingw-qemu-ga-win-101.2.0-1.el7ev on win10-64(q35) step to reproduce and actual/expected results as comment15 verify with qemu-ga-win-102.0.0-1.el8.noarch.rpm on win10-64(q35) step to verify and actual/expected results are following as above: {"execute":"guest-get-devices"} {"return": [{"driver-date": 1613692800000000000, "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19600", "id": {"device-id": 4168, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1613692800000000000, "driver-name": "Red Hat VirtIO Ethernet Adapter #2", "driver-version": "100.84.104.19600", "id": {"device-id": 4161, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1150848000000000000, "driver-name": "Microsoft Basic Display Adapter", "driver-version": "10.0.19041.1", "id": {"device-id": 4176, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1613692800000000000, "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19600", "id": {"device-id": 4163, "vendor-id": 6900, "type": "pci"}}]} Hi all, The newest qemu-ga-win came out and it has been passed from my side. the whole test loop and new cases got passed as well. No further errors and regression issues were found now. Thanks everyone for the time and effort. Cheers Dehan (In reply to dehanmeng from comment #14) > Hi all, > The newest qemu-ga-win came out and it has been passed from my side. the > whole test loop and new cases got passed as well. No further errors and > regression issues were found now. Thanks everyone for the time and effort. > > Cheers > Dehan the qemu-ga-win version is mingw-qemu-ga-win-102.0.0-2.el8 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:1959 |
Description of problem: There are some changes of qga command "get-devices" didn't changed, and file this bug as tracking to make sure those won't be missed when the needed changes are done.changes as following: [1]qga: Flatten simple union GuestDeviceId [2]qga-win: Fix guest-get-devices error API violations [3]qga: Use common time encoding for guest-get-devices 'driver-date' [4]qga: Rename guest-get-devices return member 'address' to 'id' Version-Release number of selected component (if applicable): qemu-kvm-5.2.0-3.module+el8.4.0+9499+42e58f08.x86_64 seabios-1.14.0-1.module+el8.4.0+8855+a9e237a9.x86_64 virtio-win-prewhql-0.1-193 How reproducible: 100% Steps to Reproduce: 1.boot up windows guest 2.send command to guest via qga cmd [root@dell-per440-06]nc -U /tmp/avocado_9ms7xm0w/serial-org.qemu.guest_agent.0-20210105-032815-BLpNoZnG {"execute":"guest-ping"} {"return": {}} {"execute":"guest-get-devices"} Actual results: {"return": [{"driver-date": "2021-01-11", "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19200", "address": {"type": "pci", "data": {"device-id": 4168, "vendor-id": 6900}}}, {"driver-date": "2021-01-11", "driver-name": "Red Hat VirtIO Ethernet Adapter #6", "driver-version": "100.84.104.19200", "address": {"type": "pci", "data": {"device-id": 4161, "vendor-id": 6900}}}, {"driver-date": "2021-01-12", "driver-name": "Red Hat VirtIO GPU DOD controller", "driver-version": "100.84.104.19300", "address": {"type": "pci", "data": {"device-id": 4176, "vendor-id": 6900}}}, {"driver-date": "2021-01-12", "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19300", "address": {"type": "pci", "data": {"device-id": 4163, "vendor-id": 6900}}}]} Additional info: https://lists.nongnu.org/archive/html/qemu-devel/2020-10/ Those changes can be seen from this link.