RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1920874 - Some changes of qga command "get-devices" should be fix on mingw-qemu-ga-win to qemu 5.2
Summary: Some changes of qga command "get-devices" should be fix on mingw-qemu-ga-win ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: virtio-win
Version: 8.4
Hardware: Unspecified
OS: Windows
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Virtualization Maintenance
QA Contact: dehanmeng
URL:
Whiteboard:
Depends On: 1915198
Blocks: 1935249
TreeView+ depends on / blocked
 
Reported: 2021-01-27 07:38 UTC by dehanmeng
Modified: 2021-05-18 16:26 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1935249 (view as bug list)
Environment:
Last Closed: 2021-05-18 16:25:58 UTC
Type: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1915198 0 unspecified CLOSED Rebase mingw-qemu-ga-win to qemu 5.2 2022-07-31 09:47:54 UTC

Description dehanmeng 2021-01-27 07:38:08 UTC 
Description of problem:
There are some changes of qga command "get-devices" didn't changed, and file this bug as tracking to make sure those won't be missed when the needed changes are done.changes as following:
[1]qga: Flatten simple union GuestDeviceId
[2]qga-win: Fix guest-get-devices error API violations
[3]qga: Use common time encoding for guest-get-devices 'driver-date'
[4]qga: Rename guest-get-devices return member 'address' to 'id'
 
Version-Release number of selected component (if applicable):
qemu-kvm-5.2.0-3.module+el8.4.0+9499+42e58f08.x86_64
seabios-1.14.0-1.module+el8.4.0+8855+a9e237a9.x86_64
virtio-win-prewhql-0.1-193
 
How reproducible:
100%
 
Steps to Reproduce:
1.boot up windows guest 
2.send command to guest via qga cmd
[root@dell-per440-06]nc -U /tmp/avocado_9ms7xm0w/serial-org.qemu.guest_agent.0-20210105-032815-BLpNoZnG
{"execute":"guest-ping"}
{"return": {}}
{"execute":"guest-get-devices"}
 
Actual results:
{"return": [{"driver-date": "2021-01-11", "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19200", "address": {"type": "pci", "data": {"device-id": 4168, "vendor-id": 6900}}}, {"driver-date": "2021-01-11", "driver-name": "Red Hat VirtIO Ethernet Adapter #6", "driver-version": "100.84.104.19200", "address": {"type": "pci", "data": {"device-id": 4161, "vendor-id": 6900}}}, {"driver-date": "2021-01-12", "driver-name": "Red Hat VirtIO GPU DOD controller", "driver-version": "100.84.104.19300", "address": {"type": "pci", "data": {"device-id": 4176, "vendor-id": 6900}}}, {"driver-date": "2021-01-12", "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19300", "address": {"type": "pci", "data": {"device-id": 4163, "vendor-id": 6900}}}]}
 
Additional info:
https://lists.nongnu.org/archive/html/qemu-devel/2020-10/
Those changes can be seen from this link.
Comment 1 dehanmeng 2021-02-05 02:08:39 UTC 
set ITR to rhel840 and ITM16 according to discussion with basil in mail.
thanks
Comment 6 Basil Salman 2021-02-24 22:37:41 UTC 
Hi Dehan,

Scratch build with changes:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=35146591
can this build be verified for this bug too?

Thanks in advance,
Basil
Comment 7 dehanmeng 2021-02-25 00:59:45 UTC 
(In reply to Basil Salman from comment #6)
> Hi Dehan,
> 
> Scratch build with changes:
> https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=35146591
> can this build be verified for this bug too?
> 
> Thanks in advance,
> Basil

Hi Basil,
Okay, sure, Will use this new build to check and update result asap. thanks for your effort, Basil.

BR
Dehan
Comment 8 dehanmeng 2021-02-25 07:25:14 UTC 
Hi Basil,
qga command {"guest-get-devices"} of new build works well. 

reproduce with previous mingw-qemu-ga-win-101.2.0-1.el7ev
step to verify:
1. boot up win2019 guest with serial and qga.
2. connect with guest and execute qga command.

Actual result;
{"execute":"guest-get-devices"}
{"return": [{"driver-date": "2021-02-02", "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19400", "address": {"type": "pci", "data": {"device-id": 4168, "vendor-id": 6900}}}, {"driver-date": "2021-02-02", "driver-name": "Red Hat VirtIO Ethernet Adapter #2", "driver-version": "100.84.104.19400", "address": {"type": "pci", "data": {"device-id": 4161, "vendor-id": 6900}}}, {"driver-date": "2006-06-21", "driver-name": "Microsoft Basic Display Adapter", "driver-version": "10.0.17763.1", "address": {"type": "pci", "data": {"device-id": 4176, "vendor-id": 6900}}}, {"driver-date": "2021-02-02", "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19400", "address": {"type": "pci", "data": {"device-id": 4163, "vendor-id": 6900}}}]}
Expected result:
return devices info of guest successfully.

Verify with this build qemu-ga-win-102.0.0-1.el8.noarch.rpm
step to verify:
1. boot up win2019 guest with serial and qga.
2. connect with guest and execute qga command.

Actually result:
{"execute":"guest-get-devices"}
{"return": [{"driver-date": 1612224000000000000, "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19400", "id": {"device-id": 4168, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1612224000000000000, "driver-name": "Red Hat VirtIO Ethernet Adapter #2", "driver-version": "100.84.104.19400", "id": {"device-id": 4161, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1150848000000000000, "driver-name": "Microsoft Basic Display Adapter", "driver-version": "10.0.17763.1", "id": {"device-id": 4176, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1612224000000000000, "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19400", "id": {"device-id": 4163, "vendor-id": 6900, "type": "pci"}}]}
Expected result:
as above.
Comment 12 Basil Salman 2021-03-06 19:58:07 UTC 
Build that resolves this bug:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=35297151
Comment 13 dehanmeng 2021-03-07 12:38:20 UTC 
reproduce with previous mingw-qemu-ga-win-101.2.0-1.el7ev on win10-64(q35)
step to reproduce and actual/expected results as comment15

verify with qemu-ga-win-102.0.0-1.el8.noarch.rpm on win10-64(q35)
step to verify and actual/expected results are following as above:
{"execute":"guest-get-devices"}
{"return": [{"driver-date": 1613692800000000000, "driver-name": "Red Hat VirtIO SCSI pass-through controller", "driver-version": "100.84.104.19600", "id": {"device-id": 4168, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1613692800000000000, "driver-name": "Red Hat VirtIO Ethernet Adapter #2", "driver-version": "100.84.104.19600", "id": {"device-id": 4161, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1150848000000000000, "driver-name": "Microsoft Basic Display Adapter", "driver-version": "10.0.19041.1", "id": {"device-id": 4176, "vendor-id": 6900, "type": "pci"}}, {"driver-date": 1613692800000000000, "driver-name": "VirtIO Serial Driver", "driver-version": "100.84.104.19600", "id": {"device-id": 4163, "vendor-id": 6900, "type": "pci"}}]}
Comment 14 dehanmeng 2021-03-11 09:57:05 UTC 
Hi all, 
The newest qemu-ga-win came out and it has been passed from my side.  the whole test loop and new cases got passed as well.  No further errors and regression issues were found now. Thanks everyone for the time and effort.

Cheers
Dehan
Comment 15 dehanmeng 2021-03-11 09:58:07 UTC 
(In reply to dehanmeng from comment #14)
> Hi all, 
> The newest qemu-ga-win came out and it has been passed from my side.  the
> whole test loop and new cases got passed as well.  No further errors and
> regression issues were found now. Thanks everyone for the time and effort.
> 
> Cheers
> Dehan

the qemu-ga-win version is mingw-qemu-ga-win-102.0.0-2.el8
Comment 19 errata-xmlrpc 2021-05-18 16:25:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1959
Note You need to log in before you can comment on or make changes to this bug.