Bug 1921913

Summary:	Review Request: golang-github-google-containerregistry - Go library and CLIs for working with container registries
Product:	[Fedora] Fedora	Reporter:	Olivier Lemasle <o.lemasle>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-01-29 18:53:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1921914

Description Olivier Lemasle 2021-01-28 20:25:26 UTC

Spec URL: https://olem.fedorapeople.org/reviews/golang-github-google-containerregistry.spec
SRPM URL: https://olem.fedorapeople.org/reviews/golang-github-google-containerregistry-0.4.0-1.fc33.src.rpm

Description:

Go library and CLIs for working with container registries.

Fedora Account System Username: olem

Comment 1 Robert-André Mauchin 🐧 2021-01-28 22:59:38 UTC

Remove of all this:

\\\
                        cmd/crane/README.md cmd/crane/rebase.md\\\
                        cmd/crane/help/README.md cmd/gcrane/README.md\\\
                        pkg/legacy/tarball/README.md pkg/name/README.md\\\
                        pkg/authn/README.md pkg/authn/k8schain/README.md\\\
                        pkg/v1/partial/README.md pkg/v1/remote/README.md\\\
                        pkg/v1/remote/transport/README.md\\\
                        pkg/v1/google/README.md pkg/v1/layout/README.md\\\
                        pkg/v1/stream/README.md pkg/v1/mutate/README.md\\\
                        pkg/v1/daemon/README.md pkg/v1/empty/README.md\\\
                        pkg/v1/tarball/README.md

%doc cmd/crane/rebase.md cmd/crane/help/README.md cmd/gcrane/README.md
%doc pkg/legacy/tarball/README.md pkg/name/README.md pkg/authn/README.md
%doc pkg/authn/k8schain/README.md pkg/v1/partial/README.md
%doc pkg/v1/remote/README.md pkg/v1/remote/transport/README.md
%doc pkg/v1/google/README.md pkg/v1/layout/README.md pkg/v1/stream/README.md
%doc pkg/v1/mutate/README.md pkg/v1/daemon/README.md pkg/v1/empty/README.md
%doc pkg/v1/tarball/README.md

Add %doc cmd/crane/doc to the binary package

 - The binary "registry" already exists in Fedora, please rename it:

dnf whatprovides "/usr/bin/registry"
Last metadata expiration check: 0:00:34 ago on Thu Jan 28 23:53:00 2021.
docker-distribution-2.6.2-12.git48294d9.fc33.x86_64 : Docker toolset to pack, ship, store, and deliver content
Repo        : fedora
Matched from:
Filename    : /usr/bin/registry


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Olivier Lemasle 2021-01-28 23:34:11 UTC

Thank you!

1. Ok for %doc, I actually hesitated...
2. I overlooked the binary name, thank you! I think I can name it containerregistry.

https://pagure.io/releng/fedora-scm-requests/issue/31941

Comment 3 Mohan Boddu 2021-01-29 17:00:38 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-containerregistry