Bug 1921914 - Review Request: golang-github-containerd-stargz-snapshotter - Fast docker image distribution plugin for containerd, based on CRFS/stargz
Summary: Review Request: golang-github-containerd-stargz-snapshotter - Fast docker ima...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1921913
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-28 20:28 UTC by Olivier Lemasle
Modified: 2021-01-29 17:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-01-29 17:30:49 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Olivier Lemasle 2021-01-28 20:28:15 UTC
Spec URL: https://olem.fedorapeople.org/reviews/golang-github-containerd-stargz-snapshotter.spec
SRPM URL: https://olem.fedorapeople.org/reviews/golang-github-containerd-stargz-snapshotter-0.3.0-1.fc33~bootstrap.src.rpm

Description:

Fast docker image distribution plugin for containerd, based on CRFS/stargz.

Fedora Account System Username: olem

Comment 1 Olivier Lemasle 2021-01-28 20:42:02 UTC
golang-github-containerd-stargz-snapshotter depends on golang-github-google-containerregistry
golang-github-google-containerregistry depends on golang-github-google-containerregistry~bootstrap.

Comment 2 Robert-André Mauchin 🐧 2021-01-28 23:13:39 UTC
Also depends on github.com/containerd/containerd/pkg/netns
Might be another cyclic dep.


 - Also contains BSD code, see NOTICE.md

# Upstream license specification: Apache-2.0
License:        ASL 2.0 and BSD


 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. You mist fix the License: before import.

Comment 3 Olivier Lemasle 2021-01-28 23:37:06 UTC
- Oops, I overlooked the BSD code, thanks.

- golang(github.com/containerd/containerd/pkg/netns) is provided by latest containerd, which I've just updated (and which does not depend on stargz-snapshotter), so that's ok.

https://pagure.io/releng/fedora-scm-requests/issue/31942

Comment 4 Robert-André Mauchin 🐧 2021-01-29 00:53:41 UTC
Are you planning on updating golang-github-docker after buildkit or should I do it?
If no please add a buildroot override for buildkit.

Comment 5 Olivier Lemasle 2021-01-29 14:16:37 UTC
@Robert-André Yes I'll update golang-github-docker. I've updated it in my copr repo: https://copr.fedorainfracloud.org/coprs/olem/moby/packages/
However, I planned updating it only on rawhide, do you want it for f33 too?

Also, I'll be on holiday tomorrow for a few days, so I hope the releng/fedora-scm-requests requests will be processed before I leave, so I can update  buildkit and docker.

Comment 6 Robert-André Mauchin 🐧 2021-01-29 15:16:45 UTC
I'd like them all in F33 please. I don't expect scm request to be processed soon, ping Igor Raits on IRC maybe?

Comment 7 Mohan Boddu 2021-01-29 17:01:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-containerd-stargz-snapshotter


Note You need to log in before you can comment on or make changes to this bug.