Bug 192490

Summary: Review Request: python-ogg - A Python wrapper for the Ogg libraries
Product: [Fedora] Fedora Reporter: Hugo Cisneiros <hugo>
Component: Package ReviewAssignee: Aurelien Bompard <gauret>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: gilles.gagniard, matthias
Target Milestone: ---Flags: jwboyer: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-05-30 09:07:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 192491, 193103    

Description Hugo Cisneiros 2006-05-20 03:03:16 UTC
Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/python-ogg.spec
SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/python-ogg-1.3-1.src.rpm
Description:

An object-oriented Python binding for the Ogg libraries. Ogg is a
multimedia bitstream format. With this you can write your own python
applications to play and encode audio files in ogg format.

Note:

Running rpmlint gave a Warning because we have a single include file (.h) in the package. Talking in IRC I thought it'll be a waste to create a whole -devel package for this file, I think it's unecessary. Feel free to comment about this. If it's really necessary, I'll split the package right away! ;)

Comment 1 Hans de Goede 2006-05-20 12:12:39 UTC
Hugo,

Good to see you're packing more stuff for FE I'm glad I sponsored you. I'll try
to review this for you, but I'm currently a bit busy. So this is as time permits. 

Because of this I'm not assigning this bug to myself untill I actually start the
review, to give other reviewers a chance to beat me to it :)

(Once a bug is assigned the person who has assigned the bug to himself is
supposed todo the review)


Comment 2 Aurelien Bompard 2006-05-25 09:23:58 UTC
* Please make a separate python-ogg-devel, because it will "Requires:
libogg-devel" ( the libogg header file is included at the top of
/usr/include/python2.4/pyogg/pyogg.h)
* Duplicate BuildRequires: libogg is already required by libogg-devel. In
general,  -devel subpackages require their main package.


Comment 3 Hugo Cisneiros 2006-05-25 10:21:58 UTC
Updated package:

Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/python-ogg.spec
SRPM URL: 
http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/python-ogg-1.3-2.src.rpm

Changes:

- Forked the package with a -devel one including the header.

Notes:

Thanks for pointing out about the BuildRequires duplicate.

Comment 4 Aurelien Bompard 2006-05-25 11:55:35 UTC
The -devel package should explicitely Require libogg-devel

Comment 5 Hugo Cisneiros 2006-05-25 12:01:20 UTC
Done.

Comment 6 Aurelien Bompard 2006-05-25 15:32:05 UTC
Review for release 2:
* RPM name is OK
* Source pyogg-1.3.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of python-ogg looks OK
* rpmlint of python-ogg-devel looks OK
* File list of python-ogg looks OK
* File list of python-ogg-devel looks OK
* Works fine

APPROVED


Comment 7 Brian Pepple 2006-05-25 18:05:06 UTC
*** Bug 193054 has been marked as a duplicate of this bug. ***

Comment 8 Hugo Cisneiros 2006-05-30 09:07:45 UTC
Imported and built. Closing.
Thanks!

Comment 9 Matthias Saou 2007-03-02 18:24:22 UTC
Existing Package CVS Request
============================
Package Name: python-ogg
NEW Short Description: Python wrapper for the Ogg libraries
NEW Owners: matthias
NEW Branches: EL-4 EL-5
InitialCC: none

Hugo Cisneiros has been AWOL :
https://www.redhat.com/archives/fedora-extras-list/2007-March/msg00017.html

(I still don't have rights to set the fedora-cvs flag...)

Comment 10 Peter Gordon 2007-03-03 03:33:24 UTC
Matthias: You need to go into the accounts administration on
https://admin.fedoraproject.org/accounts/ and request to join the "fedorabugs"
group (if you have not already done so). That's what allows you to modify bug
attributes, set/change flags, re-assign bugs, et al.

I've set the fedora-cvs flag for you to '?', which lets the CVS admins know
about your package request.