Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/python-vorbis.spec SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/python-vorbis-1.3-1.src.rpm Description: An object-oriented Python binding for the Ogg Vorbis libraries. Ogg is a multimedia bitstream format. With this you can write your own python applications to play and encode audio files in Ogg Vorbis format. Note: This requires the python-ogg library to build. Check Bug #192490.
Hugo, Good to see you're packing more stuff for FE I'm glad I sponsored you. I'll try to review this for you, but I'm currently a bit busy. So this is as time permits. Because of this I'm not assigning this bug to myself untill I actually start the review, to give other reviewers a chance to beat me to it :)
You should Buildrequire python-ogg-devel (which will already require libogg-devel, which requires libogg) -> in the end you only need to buildrequire python-devel, libogg-devel and libvorbis-devel
Package Updated: Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/python-vorbis.spec SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/python-vorbis-1.3-2.src.rpm Changes: - Improvements in BuildRequires dependencies (point to python-ogg)
You don't need to BuildRequire python-ogg, it will be added by python-ogg-devel
Done, thanks
Review for release 2: * RPM name is OK * Source pyvorbis-1.3.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED
Package Imported and built. Closing. Thanks!
Existing Package CVS Request ============================ Package Name: python-vorbis NEW Short Description: Python wrapper for the Ogg Vorbis audio libraries NEW Owners: matthias NEW Branches: EL-4 EL-5 InitialCC: none Hugo Cisneiros has been AWOL : https://www.redhat.com/archives/fedora-extras-list/2007-March/msg00017.html (I still don't have rights to set the fedora-cvs flag...)