Bug 192491 - Review Request: python-vorbis - A Python wrapper for the Ogg Vorbis audio libraries
Summary: Review Request: python-vorbis - A Python wrapper for the Ogg Vorbis audio lib...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 192490
Blocks: FE-ACCEPT 193103
TreeView+ depends on / blocked
 
Reported: 2006-05-20 03:06 UTC by Hugo Cisneiros
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-05-30 10:24:41 UTC
Type: ---
Embargoed:
jwboyer: fedora-cvs+


Attachments (Terms of Use)

Description Hugo Cisneiros 2006-05-20 03:06:48 UTC
Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/python-vorbis.spec
SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/python-vorbis-1.3-1.src.rpm
Description: 

An object-oriented Python binding for the Ogg Vorbis libraries. Ogg is
a multimedia bitstream format. With this you can write your own python
applications to play and encode audio files in Ogg Vorbis format.

Note:

This requires the python-ogg library to build. Check Bug #192490.

Comment 1 Hans de Goede 2006-05-20 12:12:47 UTC
Hugo,

Good to see you're packing more stuff for FE I'm glad I sponsored you. I'll try
to review this for you, but I'm currently a bit busy. So this is as time permits. 

Because of this I'm not assigning this bug to myself untill I actually start the
review, to give other reviewers a chance to beat me to it :)


Comment 2 Aurelien Bompard 2006-05-25 09:36:20 UTC
You should Buildrequire python-ogg-devel (which will already require
libogg-devel, which requires libogg)
 -> in the end you only need to buildrequire python-devel, libogg-devel and
libvorbis-devel

Comment 3 Hugo Cisneiros 2006-05-25 10:29:16 UTC
Package Updated:

Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/python-vorbis.spec
SRPM URL: 
http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/python-vorbis-1.3-2.src.rpm

Changes:

- Improvements in BuildRequires dependencies (point to python-ogg)

Comment 4 Aurelien Bompard 2006-05-25 11:58:05 UTC
You don't need to BuildRequire python-ogg, it will be added by python-ogg-devel

Comment 5 Hugo Cisneiros 2006-05-25 12:04:32 UTC
Done, thanks

Comment 6 Aurelien Bompard 2006-05-25 15:33:52 UTC
Review for release 2:
* RPM name is OK
* Source pyvorbis-1.3.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine
APPROVED

Comment 7 Hugo Cisneiros 2006-05-30 10:24:41 UTC
Package Imported and built. Closing.
Thanks!

Comment 8 Matthias Saou 2007-03-02 18:24:14 UTC
Existing Package CVS Request
============================
Package Name: python-vorbis
NEW Short Description: Python wrapper for the Ogg Vorbis audio libraries
NEW Owners: matthias
NEW Branches: EL-4 EL-5
InitialCC: none

Hugo Cisneiros has been AWOL :
https://www.redhat.com/archives/fedora-extras-list/2007-March/msg00017.html

(I still don't have rights to set the fedora-cvs flag...)


Note You need to log in before you can comment on or make changes to this bug.