Bug 192574

Summary:	Review Request: perl-Data-Structure-Util
Product:	[Fedora] Fedora	Reporter:	Steven Pritchard <steve>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-23 21:51:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 192575

Description Steven Pritchard 2006-05-20 21:24:41 UTC

Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Data-Structure-Util/perl-Data-Structure-Util.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Data-Structure-Util-0.11-1.src.rpm
Description:
Data::Structure::Util is a toolbox to manipulate the data inside a data
structure. It can process an entire tree and perform the operation
requested on each appropriate element.

Comment 1 Jason Tibbitts 2006-05-23 02:37:55 UTC

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   3cbec998cd7c55b1244b3f782569b552  Data-Structure-Util-0.11.tar.gz
   3cbec998cd7c55b1244b3f782569b552  Data-Structure-Util-0.11.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   Util.so()(64bit)
   perl(Data::Structure::Util) = 0.11
   perl-Data-Structure-Util = 0.11-1.fc6
  -
   perl(:MODULE_COMPAT_5.8.8)
   perl(AutoLoader)
   perl(Data::Dumper)
   perl(Digest::MD5)
   perl(DynaLoader)
   perl(Exporter)
   perl(strict)
   perl(vars)
   perl(warnings::register)
* shared libraries are present, but internal to Perl so no need to call ldconfig.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=10, Tests=126,  0 wallclock secs ( 0.46 cusr +  0.18 csys =  0.64 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* no ninjas

APPROVED

Comment 2 Steven Pritchard 2006-05-23 21:51:39 UTC

Imported into CVS, branches created, and builds requested.