Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Pipeline/perl-Pipeline.spec SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Pipeline-3.12-1.src.rpm Description: Pipelines are a mechanism to process data. They are designed to be plugged together to make fairly complex operations act in a fairly straightforward manner, cleanly, and simply.
Some notes from the test suite: t/11async................Use of uninitialized value in numeric eq (==) at /builddir/build/BUILD/Pipeline-3.12/blib/lib/Pipeline/Store.pm line 33 during global destruction. Unbalanced string table refcount: (1) for "debug" during global destruction. Unbalanced string table refcount: (1) for "dispatcher" during global destruction. Unbalanced string table refcount: (1) for "parent" during global destruction. Unbalanced string table refcount: (1) for "store" during global destruction. Scalars leaked: 1 ok Not sure what's up here. t/03colour...............skipped all skipped: - do not have Acme::Colour installed t/98compile..............skipped all skipped: - do not have File::Find::Rule installed t/99pod..................skipped all skipped: - do not have Find::File::Rule or Pod::Checker installed All tests successful, 3 tests skipped. Files=19, Tests=71, 1 wallclock secs ( 0.74 cusr + 0.20 csys = 0.94 CPU) Acme::Colour isn't in extras, but the others are and adding them as BR:s gives better coverage: All tests successful, 1 test skipped. Files=19, Tests=125, 2 wallclock secs ( 1.03 cusr + 0.27 csys = 1.30 CPU) I don't think there's any need to package Acme::Colour just for this; it's kind of, uhh, limited in scope anyway. Since there's nothing else of issue with this package, I'll go ahead and approve and you can add those when you check in. * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 52cbc818aa18f7307dc00624741e5a73 Pipeline-3.12.tar.gz 52cbc818aa18f7307dc00624741e5a73 Pipeline-3.12.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane; the duplicate requires come from unversioned dependencies that rpm picks up automatically. perl(Pipeline) = 3.12 perl(Pipeline::Analyser) = 3.12 perl(Pipeline::Base) = 3.12 perl(Pipeline::Dispatch) = 3.12 perl(Pipeline::Dumper) = 3.12 perl(Pipeline::Error::Abstract) = 3.12 perl(Pipeline::Error::AsyncResults) = 3.12 perl(Pipeline::Error::Construction) = 3.12 perl(Pipeline::Production) = 3.12 perl(Pipeline::Segment) = 3.12 perl(Pipeline::Segment::Async) = 3.12 perl(Pipeline::Segment::Async::Fork) = 3.12 perl(Pipeline::Segment::Async::Handler) = 3.12 perl(Pipeline::Segment::Async::IThreads) = 3.12 perl(Pipeline::Segment::Tester) = 3.12 perl(Pipeline::Store) = 3.12 perl(Pipeline::Store::ISA) = 3.12 perl(Pipeline::Store::Simple) = 3.12 perl-Pipeline = 3.12-1.fc6 - perl(:MODULE_COMPAT_5.8.8) perl(Class::ISA) perl(Config) perl(Data::Structure::Util) >= 0.04 perl(Data::UUID) perl(Data::UUID) >= 0.01 perl(Error) perl(Error) >= 0.15 perl(IO::Handle) perl(IO::Null) >= 0.01 perl(IO::String) >= 0.01 perl(Pipeline) perl(Pipeline::Base) perl(Pipeline::Dispatch) perl(Pipeline::Error::Abstract) perl(Pipeline::Error::AsyncResults) perl(Pipeline::Error::Construction) perl(Pipeline::Segment) perl(Pipeline::Segment::Async::Fork) perl(Pipeline::Segment::Async::Handler) perl(Pipeline::Segment::Async::IThreads) perl(Pipeline::Store) perl(Pipeline::Store::Simple) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) perl(warnings::register) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass (after adding the two BR:s above): All tests successful, 1 test skipped. Files=19, Tests=125, 2 wallclock secs ( 1.03 cusr + 0.27 csys = 1.30 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED
(In reply to comment #1) > Some notes from the test suite: > > t/11async................Use of uninitialized value in numeric eq (==) at > /builddir/build/BUILD/Pipeline-3.12/blib/lib/Pipeline/Store.pm line 33 during > global destruction. > Unbalanced string table refcount: (1) for "debug" during global destruction. > Unbalanced string table refcount: (1) for "dispatcher" during global destruction. > Unbalanced string table refcount: (1) for "parent" during global destruction. > Unbalanced string table refcount: (1) for "store" during global destruction. > Scalars leaked: 1 > ok > > Not sure what's up here. I opened a ticket for this. http://rt.cpan.org/Ticket/Display.html?id=19481 > t/98compile..............skipped > all skipped: - do not have File::Find::Rule installed > t/99pod..................skipped > all skipped: - do not have Find::File::Rule or Pod::Checker installed [...] > Acme::Colour isn't in extras, but the others are and adding them as BR:s gives > better coverage: Pod::Checker is a core module, so I just needed to add File::Find::Rule. Fixed in -2, in CVS. > t/03colour...............skipped > all skipped: - do not have Acme::Colour installed [...] > I don't think there's any need to package Acme::Colour just for this; it's kind > of, uhh, limited in scope anyway. Agreed. Anything in the Acme namespace is probably of dubious value.
Imported into CVS, branches created, and builds requested.