Bug 1927011

Summary: Review Request: rust-sev - Library for AMD SEV
Product: [Fedora] Fedora Reporter: Connor Kuehl <ckuehl>
Component: Package ReviewAssignee: Cole Robinson <crobinso>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: crobinso, package-review
Target Milestone: ---Flags: crobinso: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-05 14:28:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Connor Kuehl 2021-02-09 20:17:45 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/ckuehl/rust-sev/fedora-rawhide-x86_64/01955939-rust-sev/rust-sev.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ckuehl/rust-sev/fedora-rawhide-x86_64/01955939-rust-sev/rust-sev-0.1.0-1.fc34.src.rpm
Description: Library for AMD SEV
Fedora Account System Username: ckuehl

This is a library for developing against the AMD Secure Encrypted Virtualization feature found in EPYC processors.

I am one of the upstream maintainers for this project.

Successful build on the COPR frontend here: https://copr.fedorainfracloud.org/coprs/ckuehl/rust-sev/build/1955939/
Comment 1 Cole Robinson 2021-02-23 15:43:13 UTC 
Looks good to me, setting fedora-review+. Only things I noticed worth commenting on:

Generic:
[ ]: Changelog in prescribed format.

The changelog timestamp is new to me, and it's not listed as an acceptable form in the packaging guidelines, so please fix that before pushing. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs


Rpmlint
-------
rust-sev-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/sev-0.1.0/.cargo-checksum.json

  Seems common in other rust packages so I think it's fine
Comment 2 Mohan Boddu 2021-03-01 16:10:51 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sev