Bug 1927011 - Review Request: rust-sev - Library for AMD SEV
Summary: Review Request: rust-sev - Library for AMD SEV
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-09 20:17 UTC by Connor Kuehl
Modified: 2021-04-05 14:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-04-05 14:28:16 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)

Description Connor Kuehl 2021-02-09 20:17:45 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ckuehl/rust-sev/fedora-rawhide-x86_64/01955939-rust-sev/rust-sev.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ckuehl/rust-sev/fedora-rawhide-x86_64/01955939-rust-sev/rust-sev-0.1.0-1.fc34.src.rpm
Description: Library for AMD SEV
Fedora Account System Username: ckuehl

This is a library for developing against the AMD Secure Encrypted Virtualization feature found in EPYC processors.

I am one of the upstream maintainers for this project.

Successful build on the COPR frontend here: https://copr.fedorainfracloud.org/coprs/ckuehl/rust-sev/build/1955939/

Comment 1 Cole Robinson 2021-02-23 15:43:13 UTC
Looks good to me, setting fedora-review+. Only things I noticed worth commenting on:

Generic:
[ ]: Changelog in prescribed format.

The changelog timestamp is new to me, and it's not listed as an acceptable form in the packaging guidelines, so please fix that before pushing. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs


Rpmlint
-------
rust-sev-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/sev-0.1.0/.cargo-checksum.json

  Seems common in other rust packages so I think it's fine

Comment 2 Mohan Boddu 2021-03-01 16:10:51 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sev


Note You need to log in before you can comment on or make changes to this bug.