Bug 1927907
Summary: | Latest release sssd 2.4.1 hard requires Python 3 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonathan Lebon <jlebon> |
Component: | sssd | Assignee: | Alexey Tikhonov <atikhono> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 34 | CC: | abokovoy, atikhono, jhrozek, lslebodn, mzidek, pbrezina, sbose, ssorce, sssd-maintainers |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | sssd-2.4.2-2.fc34 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-03-14 16:51:06 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jonathan Lebon
2021-02-11 19:42:07 UTC
Hi Jonathan, do I understand correctly that you are fine with ``` %package tools ... Requires: python3-sssdconfig = %{version}-%{release} ``` that was in the spec file even before this rebase (i.e. you do not pull sssd-tools in Fedora CoreOS)? Change you mention was introduced upstream in https://github.com/SSSD/sssd/commit/5eb4d5c8e02c4c2ed32bee7269cf681b68613ed9 , so this is basically what RHEL was using. And it's been there about 7 years, so probably nobody remembers the reason anymore. In general this bz is a regression of bz 1667444 So I think we can fix it back to 'Suggests' at least conditionally for Fedora, but in general I don't see a reason to hard require in on RHEL as well. Sumit, Pavel, what would you say? Hi, please note the 'sssd' package is a meta package which just pulls in other packages. E.g. sub-packages like e.g. sssd-ad for Active Directory integration are listed in 'Requires:' as well. Is this kind of integration expected for Fedora CoreOS? If not it might be more suitable to not include the 'sssd' package but only 'sssd-common' and 'sssd-kcm' as it is in the Fedora minimal installation. Nevertheless I think it is ok to change 'Requires' to 'Suggests' for 'python3-sssdconfig'. bye, Sumit (In reply to Sumit Bose from comment #2) > Hi, > > please note the 'sssd' package is a meta package which just pulls in other > packages. E.g. sub-packages like e.g. sssd-ad for Active Directory > integration are listed in 'Requires:' as well. Is this kind of integration > expected for Fedora CoreOS? If not it might be more suitable to not include > the 'sssd' package but only 'sssd-common' and 'sssd-kcm' as it is in the > Fedora minimal installation. Yes, it was discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1667444#c1 already... I agree it makes sense for CoreOS team to review their approach here... > Nevertheless I think it is ok to change 'Requires' to 'Suggests' for > 'python3-sssdconfig'. Ok, thanks. JFTR: I read this as "and on RHEL as well". Upstream PR: https://github.com/SSSD/sssd/pull/5500 > And it's been there about 7 years, so probably nobody remembers the reason anymore.
python3-sssdconfig was never required on rhel7 because it has never been there.
python-sssdconfig was required because of authonfig did not want to require it due to "optional" dependency on python-sssdconfig
but it was required for proper functionality of authconfig for sssd
(In reply to Lukas Slebodnik from comment #5) > > And it's been there about 7 years, so probably nobody remembers the reason anymore. > > python3-sssdconfig was never required on rhel7 because it has never been > there. > python-sssdconfig was required because of authonfig did not want to require > it due to "optional" dependency on python-sssdconfig > but it was required for proper functionality of authconfig for sssd Yes, I meant 'python-sssdconfig' and just cut it short. Thank you for the explanation. > please note the 'sssd' package is a meta package which just pulls in other packages. E.g. sub-packages like e.g. sssd-ad for Active Directory integration are listed in 'Requires:' as well. Is this kind of integration expected for Fedora CoreOS? If not it might be more suitable to not include the 'sssd' package but only 'sssd-common' and 'sssd-kcm' as it is in the Fedora minimal installation.
Thanks, I think that makes sense as well. I don't think we can remove all the sssd packages we've been shipping so far, but at least we can freeze on the set we're currently shipping.
Pushed PR: https://github.com/SSSD/sssd/pull/5500 * `master` * b1f4dc82a5f9d30121f641430c9cbbb804686974 - SPEC: don't hard require python3-sssdconfig in a meta package |