Bug 1667444 - [RFE] Making python3-sssdconfig sub-package as Recommends for sssd sub-package instead of Requires
Summary: [RFE] Making python3-sssdconfig sub-package as Recommends for sssd sub-packag...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: sssd
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: sssd-maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-18 14:13 UTC by Sinny Kumari
Modified: 2020-07-08 11:23 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-08 11:23:18 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Sinny Kumari 2019-01-18 14:13:55 UTC
Description of problem:
In Fedora CoreOS we are trying to not have Python dependencies in base host - https://github.com/coreos/fedora-coreos-tracker/blob/master/Design.md#approach-towards-shipping-Python. We would like to provide sssd meta sub-package in FCOS base host system. Currently, sssd sub-package also pulls in python3-sssdconfig as its dependencies, which I think not needed for our usecase.

Can we make python3-sssdconfig as Recommends instead of Requires in spec file (https://src.fedoraproject.org/rpms/sssd/blob/master/f/sssd.spec#_136) so that sssd doesn't pulls in Python dependencies by default?

Any other suggestion will be appreciated too

Comment 1 Lukas Slebodnik 2019-01-18 14:27:11 UTC
(In reply to Sinny Kumari from comment #0)
> Description of problem:
> In Fedora CoreOS we are trying to not have Python dependencies in base host

As you can see sssd is just meta-package. So you can require just necessary cumpackages
on  Fedora CoreOS e.g. jsut sssd-common of sssd-ipa/sssd-ad


> -
> https://github.com/coreos/fedora-coreos-tracker/blob/master/Design.
> md#approach-towards-shipping-Python. We would like to provide sssd meta
> sub-package in FCOS base host system. Currently, sssd sub-package also pulls
> in python3-sssdconfig as its dependencies, which I think not needed for our
> usecase.
> 
> Can we make python3-sssdconfig as Recommends instead of Requires in spec
> file (https://src.fedoraproject.org/rpms/sssd/blob/master/f/sssd.spec#_136)
> so that sssd doesn't pulls in Python dependencies by default?
> 
> Any other suggestion will be appreciated too
There are already weak dependencies in sssd. And because sssd it self does not need
the package python3-sssdconfig we might even use just Suggest.

All necessary packages already require it.
[root@host ~]# dnf repoquery --whatrequires python3-sssdconfig
Last metadata expiration check: 0:49:43 ago on Fri 18 Jan 2019 02:29:34 PM CET.
authconfig-0:7.0.1-7.fc29.x86_64
freeipa-client-0:4.7.2-1.fc30.x86_64
python3-ipaserver-0:4.7.2-1.fc30.noarch
python3-ipatests-0:4.7.2-1.fc30.noarch
sssd-0:2.0.0-6.fc30.x86_64
sssd-tools-0:2.0.0-6.fc30.x86_64

Comment 2 Sinny Kumari 2019-01-18 14:41:02 UTC
(In reply to Lukas Slebodnik from comment #1)
> (In reply to Sinny Kumari from comment #0)
> > Description of problem:
> > In Fedora CoreOS we are trying to not have Python dependencies in base host
> 
> As you can see sssd is just meta-package. So you can require just necessary
> cumpackages
> on  Fedora CoreOS e.g. jsut sssd-common of sssd-ipa/sssd-ad
> 
> 
> > -
> > https://github.com/coreos/fedora-coreos-tracker/blob/master/Design.
> > md#approach-towards-shipping-Python. We would like to provide sssd meta
> > sub-package in FCOS base host system. Currently, sssd sub-package also pulls
> > in python3-sssdconfig as its dependencies, which I think not needed for our
> > usecase.
> > 
> > Can we make python3-sssdconfig as Recommends instead of Requires in spec
> > file (https://src.fedoraproject.org/rpms/sssd/blob/master/f/sssd.spec#_136)
> > so that sssd doesn't pulls in Python dependencies by default?
> > 
> > Any other suggestion will be appreciated too
> There are already weak dependencies in sssd. And because sssd it self does
> not need
> the package python3-sssdconfig we might even use just Suggest.

Yeah, if we can make it Suggest that would be nice as well. This would be easier
to maintain than installing individual packages (as they can change over time).

Comment 3 Sinny Kumari 2019-02-14 11:06:38 UTC
(In reply to Lukas Slebodnik from comment #1)
> (In reply to Sinny Kumari from comment #0)
> > Any other suggestion will be appreciated too
> There are already weak dependencies in sssd. And because sssd it self does
> not need
> the package python3-sssdconfig we might even use just Suggest.

Sent a PR with making python3-sssdconfig as suggest - https://src.fedoraproject.org/rpms/sssd/pull-request/2

Comment 4 Sinny Kumari 2019-02-27 14:17:10 UTC
Can we please have a new build of sssd in F30 containing changes from PR https://src.fedoraproject.org/rpms/sssd/pull-request/2 ?

Comment 5 Lukas Slebodnik 2019-02-27 21:54:42 UTC
(In reply to Sinny Kumari from comment #4)
> Can we please have a new build of sssd in F30 containing changes from PR
> https://src.fedoraproject.org/rpms/sssd/pull-request/2 ?

sssd 2.1.0 was tagged few minutes age in upstream.
So, I assume this BZ should be fixed with new release in few days.

Sorry that it takes ages to release such simple fix and unblock Fedora CoreOS.
I do not have permissions to help you.

Comment 6 Sinny Kumari 2019-02-28 04:52:41 UTC
(In reply to Lukas Slebodnik from comment #5)
> (In reply to Sinny Kumari from comment #4)
> > Can we please have a new build of sssd in F30 containing changes from PR
> > https://src.fedoraproject.org/rpms/sssd/pull-request/2 ?
> 
> sssd 2.1.0 was tagged few minutes age in upstream.
> So, I assume this BZ should be fixed with new release in few days.

Great news!

> Sorry that it takes ages to release such simple fix and unblock Fedora
> CoreOS.
> I do not have permissions to help you.

You have already helped us a lot and thank you for that! We are fine with
waiting for few more days to have new build comes in with 2.1.0 update.

Comment 7 Fedora Admin user for bugzilla script actions 2020-06-18 14:59:23 UTC
This package has changed maintainer in the Fedora.
Reassigning to the new maintainer of this component.

Comment 8 Pavel Březina 2020-07-08 11:23:18 UTC
This seems to be already done:
https://src.fedoraproject.org/rpms/sssd/c/80cc892c48bfa8d21c5736442ed838bf576b516b?branch=master


Note You need to log in before you can comment on or make changes to this bug.