Bug 1929282

Summary:	Making a large selection causes crash of all gnome-terminal instances
Product:	[Fedora] Fedora	Reporter:	Chris Murphy <bugzilla>
Component:	vte291	Assignee:	Kalev Lember <klember>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	34	CC:	awilliam, gnome-sig, gwync, klember
Target Milestone:	---	Keywords:	CommonBugs
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Terminal https://fedoraproject.org/wiki/Common_F34_bugs#gnome-terminal
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-16 16:25:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Murphy 2021-02-16 16:09:43 UTC

Description of problem:

Selecting many lines of text(shift-click a range, or select-all) in gnome-terminal can result in a crash. Requires > 100,000 lines, possibly millions (upstream bug is a bit unclear if those are lines/rows or what).

Version-Release number of selected component (if applicable):
VTE 0.60.3

How reproducible:
Always, as described

Steps to Reproduce:

See upstream bug for details.

Actual results:

Crash


Expected results:

No crash


Additional info:

Difficult to reproduce by default in Fedora's GNOME Terminal: neither the menu bar (to get to an Edit -> Select All option) nor a shortcut for Select-All exist. So you've got quite a lot of scrolling to shift-click select a range big enough to trigger the bug. Also by default, there is a 10,000 line scrollback limit, which isn't enough to trigger the bug.

The problem is not limited to Fedora 34, it seems to be quite an old known bug.

Comment 1 Chris Murphy 2021-02-16 16:19:01 UTC

Upstream has a workaround for the crash, by preventing large selections. This workaround is being reverted in Fedora, i.e. if you make really large selections, you might get a crash.

Workstation WG discussion and decision:
https://pagure.io/fedora-workstation/issue/216#comment-715702


This reverts commit 73713ec0644e232fb740170e399282be778d97f9.
https://src.fedoraproject.org/rpms/vte291/c/520c892274742e3dc2ecb15be806a0f6d8682b63?branch=f33

Comment 2 Chris Murphy 2021-02-16 16:35:24 UTC

https://pagure.io/fedora-docs/release-notes/issue/660

Comment 3 Adam Williamson 2021-04-26 22:26:57 UTC

Usually things don't need to go in both release notes and common bugs. One or the other is good.

Comment 4 Chris Murphy 2021-04-27 16:16:26 UTC

Put this in CommonBugs: https://fedoraproject.org/wiki/Common_F34_bugs#GNOME_Terminal.2C_large_selection_can_cause_a_crash
Closed the Release Notes issue: https://pagure.io/fedora-docs/release-notes/issue/660