Bug 1929282 - Making a large selection causes crash of all gnome-terminal instances
Summary: Making a large selection causes crash of all gnome-terminal instances
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: vte291
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Terminal https://fedoraproject.org/wi...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-16 16:09 UTC by Chris Murphy
Modified: 2021-04-29 20:15 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-16 16:25:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-terminal issues 288 0 None None None 2021-02-16 16:10:00 UTC

Description Chris Murphy 2021-02-16 16:09:43 UTC
Description of problem:

Selecting many lines of text(shift-click a range, or select-all) in gnome-terminal can result in a crash. Requires > 100,000 lines, possibly millions (upstream bug is a bit unclear if those are lines/rows or what).

Version-Release number of selected component (if applicable):
VTE 0.60.3

How reproducible:
Always, as described

Steps to Reproduce:

See upstream bug for details.

Actual results:

Crash


Expected results:

No crash


Additional info:

Difficult to reproduce by default in Fedora's GNOME Terminal: neither the menu bar (to get to an Edit -> Select All option) nor a shortcut for Select-All exist. So you've got quite a lot of scrolling to shift-click select a range big enough to trigger the bug. Also by default, there is a 10,000 line scrollback limit, which isn't enough to trigger the bug.

The problem is not limited to Fedora 34, it seems to be quite an old known bug.

Comment 1 Chris Murphy 2021-02-16 16:19:01 UTC
Upstream has a workaround for the crash, by preventing large selections. This workaround is being reverted in Fedora, i.e. if you make really large selections, you might get a crash.

Workstation WG discussion and decision:
https://pagure.io/fedora-workstation/issue/216#comment-715702


This reverts commit 73713ec0644e232fb740170e399282be778d97f9.
https://src.fedoraproject.org/rpms/vte291/c/520c892274742e3dc2ecb15be806a0f6d8682b63?branch=f33

Comment 3 Adam Williamson 2021-04-26 22:26:57 UTC
Usually things don't need to go in both release notes and common bugs. One or the other is good.


Note You need to log in before you can comment on or make changes to this bug.