Bug 1929520

Summary:	earlyoom should disable itself on upgrading to Fedora 34
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	earlyoom	Assignee:	Vitaly <vitaly>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	34	CC:	vitaly
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-18 11:35:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1929516
Bug Blocks:	1913794

Description Michel Lind 2021-02-17 04:46:44 UTC

On Fedora 34 and above, earlyoom is replaced by systemd-oomd: https://fedoraproject.org/wiki/Changes/EnableSystemdOomd

We should call `systemctl preset earlyoom.service` once fedora-release is updated to no longer carry presets enabling earlyoom, so that on upgrade earlyoom disables itself.

See e.g. https://src.fedoraproject.org/rpms/systemd/blob/0257583091a9b13d4ca7012ee3632f67af009b85/f/systemd.spec#_742-744

Comment 1 Michel Lind 2021-02-17 04:57:51 UTC

https://src.fedoraproject.org/rpms/earlyoom/pull-request/3 for the implementation. Rawhide and F34 have not diverged so I did one PR, it should be merged to both branches

Comment 2 Michel Lind 2021-02-17 22:25:08 UTC

Vitaly, could you take a look? The necessary change to fedora-release has landed, so this is now ready to be merged. If it looks good to you I can help merge and build. Thanks!

Comment 3 Vitaly 2021-02-18 11:35:14 UTC

Fixed in earlyoom-1.6.2-3.fc34.