Bug 1929520 - earlyoom should disable itself on upgrading to Fedora 34
Summary: earlyoom should disable itself on upgrading to Fedora 34
Alias: None
Product: Fedora
Classification: Fedora
Component: earlyoom
Version: 34
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
Depends On: 1929516
Blocks: 1913794
TreeView+ depends on / blocked
Reported: 2021-02-17 04:46 UTC by Michel Lind
Modified: 2021-02-18 11:35 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-02-18 11:35:14 UTC
Type: Bug

Attachments (Terms of Use)

Description Michel Lind 2021-02-17 04:46:44 UTC
On Fedora 34 and above, earlyoom is replaced by systemd-oomd: https://fedoraproject.org/wiki/Changes/EnableSystemdOomd

We should call `systemctl preset earlyoom.service` once fedora-release is updated to no longer carry presets enabling earlyoom, so that on upgrade earlyoom disables itself.

See e.g. https://src.fedoraproject.org/rpms/systemd/blob/0257583091a9b13d4ca7012ee3632f67af009b85/f/systemd.spec#_742-744

Comment 1 Michel Lind 2021-02-17 04:57:51 UTC
https://src.fedoraproject.org/rpms/earlyoom/pull-request/3 for the implementation. Rawhide and F34 have not diverged so I did one PR, it should be merged to both branches

Comment 2 Michel Lind 2021-02-17 22:25:08 UTC
Vitaly, could you take a look? The necessary change to fedora-release has landed, so this is now ready to be merged. If it looks good to you I can help merge and build. Thanks!

Comment 3 Vitaly 2021-02-18 11:35:14 UTC
Fixed in earlyoom-1.6.2-3.fc34.

Note You need to log in before you can comment on or make changes to this bug.