Bug 1931054

*** Bug 1576056 has been marked as a duplicate of this bug. ***

 - Requires should be autodetected:

Requires:       python3-wcwidth

 - Please fix the URL to point to a valid homepage:

URL:            https://pypi.python.org/pypi/

 - Please use a more specific name for your archive:

Source0:        https://github.com/selectel/pyte/archive/%{version}/%{name}-{version}.tar.gz

 - Use Sphinx to build the docs in docs/

 - Consider adding examples/ to %doc

 - You should add AUTHORS and CHANGES to %doc

 - Python provides is not needed past F33 anymore:

%{?python_provide:%python_provide python3-pyte}

For previous version you should use the %py_provides macro instead:

%py_provides python3-pyte

Seee https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro

 - I meant
 
Source0:        https://github.com/selectel/pyte/archive/%{version}/%{name}-%{version}.tar.gz

It seems the docs building need network access. I propose you this patch to deal with it:

==================================================================================
diff -up pyte-0.8.0/docs/conf.py.orig pyte-0.8.0/docs/conf.py
--- pyte-0.8.0/docs/conf.py.orig	2018-04-06 22:45:37.000000000 +0200
+++ pyte-0.8.0/docs/conf.py	2021-02-21 02:27:31.771179277 +0100
@@ -27,9 +27,8 @@ sys.path.insert(0, os.path.abspath('..')
 # coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
 extensions = ['sphinx.ext.autodoc',
               'sphinx.ext.todo',
-              'sphinx.ext.intersphinx',
-              'sphinx.ext.doctest',
-              'sphinx.ext.linkcode']
+              'sphinx.ext.doctest']
+
 
 # Add any paths that contain templates here, relative to this directory.
 templates_path = ['_templates']
@@ -90,46 +89,6 @@ pygments_style = 'sphinx'
 # A list of ignored prefixes for module index sorting.
 #modindex_common_prefix = []
 
-linkcode_base_url = "https://github.com/selectel/pyte/tree/"
-
-def resolve_tag():
-    from urllib.request import urlopen
-    from urllib.error import HTTPError
-    try:
-        urlopen(linkcode_base_url + release)
-    except HTTPError:
-        return "master"
-    else:
-        return release
-
-
-tag = resolve_tag()
-
-
-# Resolve function for the linkcode extension.
-def linkcode_resolve(domain, info):
-    def find_source():
-        # try to find the file and line number, based on code from numpy:
-        # https://github.com/numpy/numpy/blob/master/doc/source/conf.py#L286
-        obj = sys.modules[info['module']]
-        for part in info['fullname'].split('.'):
-            obj = getattr(obj, part)
-
-        import inspect
-        import os
-        import pyte
-        fn = inspect.getsourcefile(obj)
-        fn = os.path.relpath(fn, os.path.dirname(pyte.__file__))
-        source, lineno = inspect.getsourcelines(obj)
-        return fn, lineno, lineno + len(source) - 1
-
-    try:
-        filename = 'pyte/%s#L%d-L%d' % find_source()
-    except Exception:
-        return None  # Failed to resolve source or line numbers.
-
-    return linkcode_base_url + "%s/%s" % (tag, filename)
-
 # -- Options for HTML output ---------------------------------------------------
 
 ## Read the docs style:

==================================================================================


Proposed SPEC:

==================================================================================
Name:           python-pyte
Version:        0.8.0
Release:        2%{?dist}
Summary:        In memory VT-compatible terminal emulator

License:        LGPLv3
URL:            https://github.com/selectel/pyte
Source0:        %url/archive/%{version}/%{name}-%{version}.tar.gz
# Remove network access during the docs build
Patch0:         pyte-docs.patch

BuildArch:      noarch

BuildRequires:  python3-devel
BuildRequires:  python3-pytest-runner
BuildRequires:  python3-sphinx
BuildRequires:  python3-sphinx_rtd_theme
BuildRequires:  python3-wcwidth

%description
In memory VTXXX-compatible terminal emulator.  XXX stands for a series
of video terminals, developed by DEC between 1970 and 1995.

%package     -n python3-pyte
Summary:        %{summary}

%description -n python3-pyte
In memory VTXXX-compatible terminal emulator.  XXX stands for a series
of video terminals, developed by DEC between 1970 and 1995.

%prep
%autosetup -p1 -n pyte-%{version}

%build
%py3_build

# generate html docs
sphinx-build-3 docs html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

%install
%py3_install

%check
%{__python3} setup.py test

%files -n python3-pyte
%license LICENSE
%doc AUTHORS CHANGES README
%doc examples/ html/
%{python3_sitelib}/pyte/
%{python3_sitelib}/pyte-%{version}-py*.egg-info

%changelog
* Sun Feb 07 2021 Terje Rosten <terje.rosten> - 0.8.0-2
- Remove Python 2 support
- Minor clean up

* Tue May 8 2018 Mateusz Mikuła <mati865 at gmail.com> - 0.8.0-1
- Initial packaging

==================================================================================

Thanks for quick review!

Changes done:

 - Fix source and url
 - Drop explicit requires, autodetected these days
 - Add AUTHORS and CHANGES to doc
 - Use py_provides macro for Fedora 32, automatically elsewhere
 - Add patch from Robert-Andre Mauchi to avoid network access during buil
 - Build and ship API docs in docs subpackage, include examples too

spec: https://terjeros.fedorapeople.org/python-pyte/python-pyte.spec
srpm: https://terjeros.fedorapeople.org/python-pyte/python-pyte-0.8.0-3.fc31.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=62416484

Package approved.

Please fix the typos in the changelog.

Thanks!


SCM request sent:

 https://pagure.io/releng/fedora-scm-requests/issue/32642

Could you please consider to have a look at
 
https://bugzilla.redhat.com/show_bug.cgi?id=1925940

too? I think it should be fairly simple.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyte

FEDORA-2021-8daed5aa8d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8daed5aa8d

FEDORA-2021-b1cb08fefa has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b1cb08fefa

FEDORA-2021-8daed5aa8d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8daed5aa8d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8daed5aa8d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-b1cb08fefa has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b1cb08fefa \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b1cb08fefa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-0a59210dfe has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0a59210dfe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0a59210dfe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-8daed5aa8d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-b1cb08fefa has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-0a59210dfe has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.